fix: adding the key requires double enter before it gets added as label key after the first label #6296
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…el key after the first label
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
1 similar comment
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 1b0eea1 in 31 seconds
More details
- Looked at
14lines of code in1files - Skipped
0files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. frontend/src/container/FormAlertRules/labels/index.tsx:141
- Draft comment:
The conditionstate.value === 'Idle'is checked twice in theonKeyUpevent handler. Consider removing the redundant check to optimize the code. - Reason this comment was not posted:
Comment looked like it was already resolved.
2. frontend/src/container/FormAlertRules/labels/index.tsx:145
- Draft comment:
Avoid using inline styles. Consider using external stylesheets, CSS classes, or styled components instead. This applies to lines 118 and 133. - Reason this comment was not posted:
Comment was on unchanged code.
Workflow ID: wflow_3IR8dZ6KdotTsHS0
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
SagarRajput-7
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related Issues / PR's
close https://github.com/SigNoz/engineering-pod/issues/1945
Screenshots
Before:
new.alert.label.issue.-.before.mov
After:
new.alert.label.issue.-.after.mov
NA
Affected Areas and Manually Tested Areas