chore: add k8s daemonset resources

[srikanthccv]

Summary

Part of #5373

---

Important

Add support for Kubernetes DaemonSets in query service with new API routes, repository methods, and models.

• Behavior:
  • Adds support for Kubernetes DaemonSets in APIHandler with new routes for attribute keys, values, and list in http_handler.go and infra.go.
  • Introduces DaemonSetsRepo in daemonsets.go to handle DaemonSet metrics and attributes.
• Models:
  • Adds DaemonSetListRequest, DaemonSetListResponse, and DaemonSetListRecord to infra.go.
• Misc:
  • Adds getParamsForTopDaemonSets() in common.go for query parameter handling.
  • Updates APIHandler to include daemonsetsRepo in http_handler.go.

^{This description was created by for 533bbbf. It will automatically update as commits are pushed.}

[ellipsis-dev]

❌ Changes requested. Reviewed everything up to 533bbbf in 1 minute and 12 seconds

More details

• Looked at 608 lines of code in 5 files
• Skipped 0 files when reviewing.
• Skipped posting 5 drafted comments based on config settings.

1. pkg/query-service/app/inframetrics/daemonsets.go:100

• Draft comment:
  Consider removing the hardcoded metric name k8s_pod_cpu_utilization and support keys from any pod metric. This will make the code more flexible and adaptable to changes in metric names.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The code in the PR seems to be consistent with the existing pattern for handling different Kubernetes resources. However, there is a potential issue with the use of hardcoded metric names and the lack of error handling for certain operations.

2. pkg/query-service/app/inframetrics/daemonsets.go:112

• Draft comment:
  Ensure that only resource attributes are returned when possible. This will help in maintaining consistency and clarity in the data being processed.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The code in the PR seems to be consistent with the existing pattern for handling different Kubernetes resources. However, there is a potential issue with the use of hardcoded metric names and the lack of error handling for certain operations.

3. pkg/query-service/app/inframetrics/daemonsets.go:171

• Draft comment:
  Ensure that the query replacement from local to distributed is correct and does not affect the intended query logic.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The code in the PR seems to be consistent with the existing pattern for handling different Kubernetes resources. However, there is a potential issue with the use of hardcoded metric names and the lack of error handling for certain operations.

4. pkg/query-service/app/inframetrics/daemonsets.go:245

• Draft comment:
  Consider handling cases where req.OrderBy.ColumnName might not exist in queryNamesForDaemonSets. This will prevent potential runtime errors.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The code in the PR seems to be consistent with the existing pattern for handling different Kubernetes resources. However, there is a potential issue with the use of hardcoded metric names and the lack of error handling for certain operations.

5. pkg/query-service/app/http_handler.go:123

• Draft comment:
  Avoid using the component/index.tsx file structure approach, as it makes it difficult to debug and find components using global search tools like VS Code. This comment applies to the entire file structure, not just this line.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The code is adding a new repository for DaemonSets in the APIHandler, which is consistent with the existing pattern for other resources like deployments, clusters, etc. This is appropriate and does not violate any of the specified rules.

Workflow ID: wflow_pYCvNn15AFCIuqOZ

---

Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.