fix(docker): otel-collector-migrator command fixed in docker-compose-core.yml #6564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome to the SigNoz community! Thank you for your first pull request and making this project better. 🤗 |
|
|
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to d58e33a in 22 seconds
More details
- Looked at
14lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. deploy/docker/clickhouse-setup/docker-compose-core.yaml:75
- Draft comment:
Ensure that the command syntax and parameters are correct for the intended operation. The changes seem appropriate for the context. - Reason this comment was not posted:
Confidence changes required:33%
The PR does not violate any of the specified rules. The changes are related to a Docker Compose file, which does not involve React components, ClickHouseReader interface, or component file structure. The changes are appropriate for the context.
Workflow ID: wflow_WfGRIBVgVxULqs6K
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
srikanthccv
approved these changes
Dec 7, 2024
|
Congrats on merging your first pull request! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed the command of the otel-collect-migrator service in
deploy/docker/clickhouse-setup/docker-compose-core.yamlImportant
Fixes
otel-collector-migratorcommand indocker-compose-core.yaml.otel-collector-migratorcommand indocker-compose-core.yamlto includesync,--dsn=tcp://clickhouse:9000, and--up=.This description was created by
for d58e33a. It will automatically update as commits are pushed.