chore: added debug statements for rbac issue #6580
Conversation
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 1934f74 in 1 minute and 24 seconds
More details
- Looked at
44lines of code in3files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. pkg/query-service/app/http_handler.go:2148
- Draft comment:
Do not add non-ClickHouse related functions to the ClickHouseReader interface. Use the DAO in the telemetry instance to access such information instead. - Reason this comment was not posted:
Comment was on unchanged code.
Workflow ID: wflow_AIpesF31YX6YyChq
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
There was a problem hiding this comment.
❌ Changes requested. Incremental review on 1a7ea09 in 47 seconds
More details
- Looked at
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. frontend/src/container/ListOfDashboard/DashboardsList.tsx:115
- Draft comment:
Avoid using inline styles. Use external stylesheets, CSS classes, or styled components instead. This issue is also present in other parts of the file. - Reason this comment was not posted:
Comment was on unchanged code.
Workflow ID: wflow_YIIYe51DOYFdW4kt
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 39566bf in 38 seconds
More details
- Looked at
55lines of code in2files - Skipped
0files when reviewing. - Skipped posting
3drafted comments based on config settings.
1. frontend/src/AppRoutes/utils.ts:55
- Draft comment:
Avoid usingconsole.tracefor logging in production code. Consider using a proper logging mechanism or remove it after debugging. - Reason this comment was not posted:
Comment was on unchanged code.
2. frontend/src/container/ListOfDashboard/DashboardsList.tsx:106
- Draft comment:
Avoid usingconsole.infofor logging in production code. Consider using a proper logging mechanism or remove it after debugging. This applies to other instances ofconsole.infoin this file as well. - Reason this comment was not posted:
Comment was on unchanged code.
3. frontend/src/container/ListOfDashboard/DashboardsList.tsx:117
- Draft comment:
Avoid using inline styles. Use external stylesheets, CSS classes, or styled components instead. This is also applicable at line 979. - Reason this comment was not posted:
Comment was on unchanged code.
Workflow ID: wflow_NzJJ60pv6ymxEals
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
|
This is no longer needed ! |
Summary
Related Issues / PR's
Screenshots
NA
Affected Areas and Manually Tested Areas
Important
Add debug logging in
utils.ts,DashboardsList.tsx, andhttp_handler.gofor RBAC issue diagnosis.Sentry.captureEventandconsole.traceinafterLogin()inutils.tsto loggetUserResponsepayload.Sentry.captureEventandconsole.infoinDashboardsList()inDashboardsList.tsxto log user email, role, andcreateNewDashboardpermission.zap.L().InfoingetUser()inhttp_handler.goto log user ID, email, and role.This description was created by
for 39566bf. It will automatically update as commits are pushed.