Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: smartTraceAlgo for new schema #6602

Merged
merged 2 commits into from
Dec 10, 2024
Merged

Conversation

nityanandagohain
Copy link
Member

@nityanandagohain nityanandagohain commented Dec 7, 2024

Part of #5713

This was not added to searchTracesV2, so added it now .


Important

Enhance SearchTracesV2 in reader.go to support a smart trace algorithm for large trace data handling.

  • Functionality:
    • SearchTracesV2 in reader.go now accepts a smartTraceAlgorithm function parameter.
    • Applies smartTraceAlgorithm if searchScanResponses exceeds SpansRenderLimit and SmartTraceDetail feature is enabled.
    • Logs telemetry event TELEMETRY_EVENT_LARGE_TRACE_OPENED if smart algorithm is applied.
  • Error Handling:
    • Returns error if smartTraceAlgorithm fails.
  • Telemetry:
    • Sends telemetry data when trace size exceeds MaxSpansInTrace.

This description was created by Ellipsis for f6687c1. It will automatically update as commits are pushed.

@github-actions github-actions bot added the bug Something isn't working label Dec 7, 2024
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Reviewed everything up to f6687c1 in 47 seconds

More details
  • Looked at 57 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. pkg/query-service/app/clickhouseReader/reader.go:1320
  • Draft comment:
    Do not add non-ClickHouse related functions like GetDisks to the ClickHouseReader interface. Use the DAO in the telemetry instance instead. This applies to other similar functions as well.
  • Reason this comment was not posted:
    Comment was on unchanged code.

Workflow ID: wflow_Ty0DCjqq6waohson


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@nityanandagohain nityanandagohain merged commit f9d4cf1 into develop Dec 10, 2024
16 checks passed
@nityanandagohain nityanandagohain deleted the fix/smart-trace branch December 10, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working docs not required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants