-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(licenses): deprecate licenses v2 #6626
Conversation
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to 8d05280 in 26 seconds
More details
- Looked at
435
lines of code in6
files - Skipped
0
files when reviewing. - Skipped posting
2
drafted comments based on config settings.
1. ee/query-service/app/api/license.go:102
- Draft comment:
Remove the comment referencinglicenses v3
as it is no longer relevant after the deprecation of licenses v2. - Reason this comment was not posted:
Confidence changes required:50%
The PR removes theUseLicensesV3
flag from the codebase, which is a part of the deprecation of licenses v2. However, there are still some references toUseLicensesV3
in the comments, which should be updated to reflect the changes made in the code.
2. ee/query-service/app/api/license.go:105
- Draft comment:
Avoid using inline styles in React components. Instead, use external stylesheets, CSS classes, or styled components. This comment applies to other instances of inline styles in the codebase as well. - Reason this comment was not posted:
Comment was not on a valid diff hunk.
Workflow ID: wflow_cUVM0tznOQ1NOCSX
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should also remove the unused Validate
and Activate
methods from integrations as well
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on 547f26a in 58 seconds
More details
- Looked at
91
lines of code in3
files - Skipped
0
files when reviewing. - Skipped posting
2
drafted comments based on config settings.
1. pkg/query-service/app/http_handler.go:166
- Draft comment:
TheUseLicensesV3
flag should be removed fromAPIHandlerOpts
as it is deprecated. This is consistent with the changes made inapi.go
andserver.go
. - Reason this comment was not posted:
Comment looked like it was already resolved.
2. ee/query-service/app/server.go:83
- Draft comment:
Avoid using thecomponent/index.tsx
file structure approach. It makes it difficult to debug and find components using global search tools. - Reason this comment was not posted:
Comment was not on a valid diff hunk.
Workflow ID: wflow_OmYY4xzBrSJK2hsV
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Removed from integrations as well |
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on 51aba83 in 28 seconds
More details
- Looked at
123
lines of code in2
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. ee/query-service/integrations/signozio/signozio.go:10
- Draft comment:
Avoid using hardcoded color values. Use design tokens or predefined color constants instead. This issue is also present in other parts of the code. - Reason this comment was not posted:
Comment was not on a valid diff hunk.
Workflow ID: wflow_Eut4rKxdmwWabCnQ
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary
deprecate licenses v2
Important
Deprecates licenses v2 by removing related flags and logic, transitioning fully to licenses v3.
UseLicensesV3
flag fromAPIHandlerOptions
inapi.go
andServerOptions
inserver.go
.applyLicense()
inlicense.go
to useActivateV3()
.GetActiveLicense()
indb.go
.manager.go
.useLicensesV3
parameter fromStartManager()
inmanager.go
andNewLicenseRepo()
indb.go
.SetActive()
,LoadActiveLicense()
, andValidator()
frommanager.go
.useLicensesV3
flag handling inmain.go
.This description was created by for 51aba83. It will automatically update as commits are pushed.