Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(licenses): deprecate licenses v2 #6626

Merged
merged 6 commits into from
Dec 16, 2024
Merged

Conversation

grandwizard28
Copy link
Collaborator

@grandwizard28 grandwizard28 commented Dec 12, 2024

Summary

deprecate licenses v2


Important

Deprecates licenses v2 by removing related flags and logic, transitioning fully to licenses v3.

  • Deprecation of Licenses V2:
    • Remove UseLicensesV3 flag from APIHandlerOptions in api.go and ServerOptions in server.go.
    • Update applyLicense() in license.go to use ActivateV3().
    • Remove v2 logic from GetActiveLicense() in db.go.
    • Remove v2 license activation and validation logic from manager.go.
  • Code Cleanup:
    • Remove useLicensesV3 parameter from StartManager() in manager.go and NewLicenseRepo() in db.go.
    • Remove deprecated functions SetActive(), LoadActiveLicense(), and Validator() from manager.go.
    • Remove useLicensesV3 flag handling in main.go.

This description was created by Ellipsis for 51aba83. It will automatically update as commits are pushed.

Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added the enhancement New feature or request label Dec 12, 2024
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 8d05280 in 26 seconds

More details
  • Looked at 435 lines of code in 6 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. ee/query-service/app/api/license.go:102
  • Draft comment:
    Remove the comment referencing licenses v3 as it is no longer relevant after the deprecation of licenses v2.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR removes the UseLicensesV3 flag from the codebase, which is a part of the deprecation of licenses v2. However, there are still some references to UseLicensesV3 in the comments, which should be updated to reflect the changes made in the code.
2. ee/query-service/app/api/license.go:105
  • Draft comment:
    Avoid using inline styles in React components. Instead, use external stylesheets, CSS classes, or styled components. This comment applies to other instances of inline styles in the codebase as well.
  • Reason this comment was not posted:
    Comment was not on a valid diff hunk.

Workflow ID: wflow_cUVM0tznOQ1NOCSX


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Collaborator

@vikrantgupta25 vikrantgupta25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should also remove the unused Validate and Activate methods from integrations as well

Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 547f26a in 58 seconds

More details
  • Looked at 91 lines of code in 3 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. pkg/query-service/app/http_handler.go:166
  • Draft comment:
    The UseLicensesV3 flag should be removed from APIHandlerOpts as it is deprecated. This is consistent with the changes made in api.go and server.go.
  • Reason this comment was not posted:
    Comment looked like it was already resolved.
2. ee/query-service/app/server.go:83
  • Draft comment:
    Avoid using the component/index.tsx file structure approach. It makes it difficult to debug and find components using global search tools.
  • Reason this comment was not posted:
    Comment was not on a valid diff hunk.

Workflow ID: wflow_OmYY4xzBrSJK2hsV


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@grandwizard28
Copy link
Collaborator Author

Removed from integrations as well

Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 51aba83 in 28 seconds

More details
  • Looked at 123 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. ee/query-service/integrations/signozio/signozio.go:10
  • Draft comment:
    Avoid using hardcoded color values. Use design tokens or predefined color constants instead. This issue is also present in other parts of the code.
  • Reason this comment was not posted:
    Comment was not on a valid diff hunk.

Workflow ID: wflow_Eut4rKxdmwWabCnQ


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Collaborator

@vikrantgupta25 vikrantgupta25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grandwizard28 grandwizard28 enabled auto-merge (squash) December 16, 2024 10:19
@grandwizard28 grandwizard28 merged commit 951593b into develop Dec 16, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs not required enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants