feat: implement clusters list table for infra monitoring #6628
Conversation
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
amlannandy
force-pushed
the
feat/infra-monitoring-k8s-nodes
branch
4 times, most recently
from
26a6959 to
b5d57e1
Compare
amlannandy
changed the base branch from
feat/infra-monitoring-k8s-nodes
to
feat/infra-monitoring-k8s
amlannandy
force-pushed
the
feat/infra-monitoring-k8s-clusters
branch
from
363d0e7 to
04a2a31
Compare
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 21a78f1 in 2 minutes and 3 seconds
More details
- Looked at
960lines of code in8files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. frontend/src/container/InfraMonitoringK8s/Clusters/K8sClustersList.tsx:112
- Draft comment:
Avoid using inline styles in React components. Use external stylesheets, CSS classes, or styled components instead. This applies to other instances in the code as well. - Reason this comment was not posted:
Comment was not on a valid diff hunk.
Workflow ID: wflow_OWnIjk1DnyqVdvEW
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| items: [], | ||
| op: 'and', | ||
| }, | ||
| orderBy: { columnName: 'cpu', order: 'desc' }, |
There was a problem hiding this comment.
The default orderBy column name 'cpu' does not match any field in the K8sClustersData interface. Consider using a valid field name like 'cpuUsage' or 'cpuAllocatable'.
| canRemove: boolean; | ||
| } | ||
|
|
||
| export interface IEntityColumn { |
There was a problem hiding this comment.
The IEntityColumn interface is defined twice in this file. Please remove the duplicate definition.
| memoryUtilization: number; | ||
| cpuAllocatable: number; | ||
| memoryAllocatable: number; | ||
| groupedByMeta?: any; |
There was a problem hiding this comment.
The groupedByMeta property is typed as any. Consider defining a specific type for better type safety.
| return options.queryKey; | ||
| } | ||
|
|
||
| return [REACT_QUERY_KEY.GET_HOST_LIST, requestData]; |
There was a problem hiding this comment.
The queryKey uses 'GET_HOST_LIST', which might not be appropriate for clusters. Consider using a more descriptive key like 'GET_K8S_CLUSTERS_LIST'.
| return ( | ||
| <div className="pod-group"> | ||
| {groupByValues.map((value) => ( | ||
| <Tag key={value} color="#1D212D" className="pod-group-tag-item"> |
There was a problem hiding this comment.
Use design tokens or predefined color constants instead of hardcoding color values like #1D212D. This applies to other instances in the code as well.
amlannandy
force-pushed
the
feat/infra-monitoring-k8s-clusters
branch
from
21a78f1 to
a3a8f7c
Compare
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
There was a problem hiding this comment.
❌ Changes requested. Incremental review on a3a8f7c in 1 minute and 19 seconds
More details
- Looked at
922lines of code in5files - Skipped
0files when reviewing. - Skipped posting
3drafted comments based on config settings.
1. frontend/src/container/InfraMonitoringK8s/Clusters/utils.tsx:70
- Draft comment:
TheorderBycolumn 'cpu' does not exist in the data structure. Consider using a valid column name like 'cpuUsage'. - Reason this comment was not posted:
Comment was not on a valid diff hunk.
2. frontend/src/container/InfraMonitoringK8s/Clusters/utils.tsx:53
- Draft comment:
Consider defining a specific type forgroupedByMetainstead of usinganyto improve type safety. - Reason this comment was not posted:
Marked as duplicate.
3. frontend/src/container/InfraMonitoringK8s/Clusters/utils.tsx:58
- Draft comment:
Avoid using inline styles in React components. Instead, use external stylesheets, CSS classes, or styled components. - Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_Vuxm2IOGxRYpoF3F
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| handleGroupByRowClick(record); | ||
| } | ||
|
|
||
| logEvent('Infra Monitoring: K8s cluster list item clicked', { |
There was a problem hiding this comment.
The logEvent function logs clusterUID but uses record.clusterName. It should use record.clusterUID instead for accurate logging.
| return ( | ||
| <div className="pod-group"> | ||
| {groupByValues.map((value) => ( | ||
| <Tag key={value} color="#1D212D" className="pod-group-tag-item"> |
There was a problem hiding this comment.
Use design tokens or predefined color constants instead of hardcoding color values for the Tag component. This ensures consistency in design and theming.
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 26a83fb in 1 minute and 11 seconds
More details
- Looked at
142lines of code in3files - Skipped
0files when reviewing. - Skipped posting
5drafted comments based on config settings.
1. frontend/src/container/InfraMonitoringK8s/Clusters/utils.tsx:1
- Draft comment:
The label for 'Memory Utilization' should be 'Memory Utilization (bytes)' instead of 'Memory Utilization (cores)'. - Reason this comment was not posted:
Marked as duplicate.
2. frontend/src/container/InfraMonitoringK8s/Clusters/utils.tsx:162
- Draft comment:
Ensure that the label for 'Memory Utilization' indefaultAddedColumnsmatches the actual data representation, which is in bytes. - Reason this comment was not posted:
Comment did not seem useful.
3. frontend/src/container/InfraMonitoringK8s/Clusters/utils.tsx:88
- Draft comment:
Avoid using inline styles for column headers. Use external stylesheets, CSS classes, or styled components instead. This issue is also present in other column definitions in this file. - Reason this comment was not posted:
Comment was on unchanged code.
4. frontend/src/container/InfraMonitoringK8s/Clusters/utils.tsx:104
- Draft comment:
Avoid using inline styles for column headers. Use external stylesheets, CSS classes, or styled components instead. This issue is also present in other column definitions in this file. - Reason this comment was not posted:
Marked as duplicate.
5. frontend/src/container/InfraMonitoringK8s/Clusters/utils.tsx:162
- Draft comment:
Avoid using inline styles for column headers. Use external stylesheets, CSS classes, or styled components instead. This issue is also present in other column definitions in this file. - Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_o6zABtnbfDdrAdq4
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on f7f8712 in 14 seconds
More details
- Looked at
24lines of code in2files - Skipped
0files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. frontend/src/hooks/infraMonitoring/useGetK8sClustersList.ts:41
- Draft comment:
The change fromGET_HOST_LISTtoGET_CLUSTER_LISTin the query key is correct and aligns with the new feature implementation. - Reason this comment was not posted:
Confidence changes required:0%
The change fromGET_HOST_LISTtoGET_CLUSTER_LISTin the query key is correct and aligns with the new feature implementation.
2. frontend/src/hooks/infraMonitoring/useGetK8sClustersList.ts:41
- Draft comment:
Avoid using inline styles in React components. Instead, use external stylesheets, CSS classes, or styled components. This comment applies to any other instances of inline styles in the codebase. - Reason this comment was not posted:
Confidence changes required:50%
The code is well-structured and follows the rules provided. The only issue is the use of inline styles, which is not present here. The code uses external constants and hooks appropriately.
Workflow ID: wflow_ayeWwrXLplRROnxa
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
Summary
Implement the clusters list table in Infra Monitoring
Related Issues / PR's
N/A
Screenshots
N/A
Affected Areas and Manually Tested Areas
Infra Monitoring section
Important
Implement Kubernetes clusters list feature in Infra Monitoring with new API, components, and utilities.
getK8sClustersListingetK8sClustersList.tsto fetch Kubernetes clusters.K8sClustersListPayload,K8sClustersData, andK8sClustersListResponse.K8sClustersListinK8sClustersList.tsxfor displaying clusters with pagination and sorting.K8sHeaderinK8sHeader.tsxfor managing filters and group by options.utils.tsxfor data formatting and table column definitions.useGetK8sClustersListinuseGetK8sClustersList.tsfor fetching clusters data using React Query.InfraMonitoringK8s.tsxwith category selection and quick filters.This description was created by
for f7f8712. It will automatically update as commits are pushed.