fix: detach the log indicator from timestamp column

[vikrantgupta25]

Summary

• detach the log state indicator from the timestamp column as it can be re-arranged according to need

Related Issues / PR's

contributes to #6679

Screenshots

Screen.Recording.2024-12-19.at.11.15.01.PM.mov

Affected Areas and Manually Tested Areas

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to 15b8447 in 40 seconds

More details

• Looked at 139 lines of code in 5 files
• Skipped 0 files when reviewing.
• Skipped posting 3 drafted comments based on config settings.

1. frontend/src/components/Logs/TableView/useTableView.tsx:82

• Draft comment:
  Consider defining 'state-indicator' as a constant and using it throughout the code to avoid potential errors if the key needs to be changed in the future. This applies to other files as well where 'state-indicator' is used.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The code uses the 'state-indicator' key in multiple places to identify the log state indicator column. This is a good practice for consistency and clarity. However, the key is used as a string literal in multiple places, which can lead to errors if it needs to be changed in the future. It would be better to define it as a constant and use the constant throughout the code.

2. frontend/src/container/LogsExplorerList/InfinityTableView/styles.ts:28

• Draft comment:
  Use design tokens or predefined color constants instead of hardcoding color values for consistency in theming. This applies to other instances in this file as well.
• Reason this comment was not posted:
  Comment was on unchanged code.

3. frontend/src/components/Logs/TableView/useTableView.styles.scss:22

• Draft comment:
  Use design tokens or predefined color constants instead of hardcoding color values for consistency in theming. This applies to other instances in this file as well.
• Reason this comment was not posted:
  Marked as duplicate.

Workflow ID: wflow_oUQq7M14OSMdqOF8

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.