chore: cloud integrations: include cloud account id in account status response #6833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raj-k-singh
force-pushed
the
chore/aws-integration-api-include-cloud-account-id-in-status-response
branch
from
664e9a5 to
bd63d70
Compare
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to bd63d70 in 46 seconds
More details
- Looked at
49lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. pkg/query-service/tests/integration/signoz_cloud_integrations_test.go:52
- Draft comment:
Do not add non-ClickHouse related functions to the ClickHouseReader interface. Use the DAO in the telemetry instance instead. - Reason this comment was not posted:
Comment was not on a valid diff hunk.
Workflow ID: wflow_pGdWvtkL0qkJytJv
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
srikanthccv
approved these changes
Jan 16, 2025
raj-k-singh
deleted the
chore/aws-integration-api-include-cloud-account-id-in-status-response
branch
amlannandy
pushed a commit
that referenced
this pull request
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds cloud_account_id in cloud integrations account status response
Related Issues / PR's
Contributes to #6544
Important
Add
CloudAccountIdtoAccountStatusResponseand update tests to verify its presence.CloudAccountIdfield toAccountStatusResponseincontroller.go.GetAccountStatusincontroller.goto includeCloudAccountIdin response.TestAWSIntegrationAccountLifecycleinsignoz_cloud_integrations_test.goto check forCloudAccountIdin account status response.This description was created by
for bd63d70. It will automatically update as commits are pushed.