-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Centralize and Standardize Date/Time Format Handling #6925
feat: Centralize and Standardize Date/Time Format Handling #6925
Conversation
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to 94c9fe3 in 1 minute and 32 seconds
More details
- Looked at
1155
lines of code in44
files - Skipped
0
files when reviewing. - Skipped posting
3
drafted comments based on config settings.
1. frontend/src/utils/timeUtils.ts:1
- Draft comment:
The use of centralizedDATE_TIME_FORMATS
for date formatting is consistent and aligns with the PR's intent to standardize date/time handling. Good job! - Reason this comment was not posted:
Confidence changes required:0%
The code in this file is well-structured and follows best practices. The use of constants for date/time formats is consistent with the PR's intent to centralize and standardize date/time handling. The functions are clear and concise, and the use of dayjs for date manipulation is appropriate. No issues found.
2. frontend/src/pages/Integrations/IntegrationDetailPage/IntegrationDetailHeader.tsx:250
- Draft comment:
Avoid using inline styles. Consider using CSS classes or styled components instead. This is also applicable in other parts of this file. - Reason this comment was not posted:
Comment was not on a valid diff hunk.
3. frontend/src/pages/SaveView/index.tsx:222
- Draft comment:
Avoid using inline styles. Consider using CSS classes or styled components instead. This is also applicable in other parts of this file. - Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_Alcl02zF1RDR4eeZ
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on a5892ea in 34 seconds
More details
- Looked at
20
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
2
drafted comments based on config settings.
1. frontend/src/container/AlertHistory/Timeline/Graph/Graph.tsx:64
- Draft comment:
Consider usingvalues: uPlotXAxisValuesFormat
for consistency in date/time formatting in other graphs as well. - Reason this comment was not posted:
Comment looked like it was already resolved.
2. frontend/src/container/AlertHistory/Timeline/Graph/Graph.tsx:61
- Draft comment:
Avoid using inline styles in React components. Use external stylesheets, CSS classes, or styled components instead. This is applicable in other parts of the file as well. - Reason this comment was not posted:
Comment was not on a valid diff hunk.
Workflow ID: wflow_vuSswssMKNiMCHTx
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
1 similar comment
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
Summary
DATE_TIME_FORMATS
constant to maintain all date/time formats in one placeconvert24hTo12h
to support 12-hour format when neededRelated Issues / PR's
Part of https://github.com/SigNoz/engineering-pod/issues/2155
Screenshots
Before:
2025-01-27.10-10-17.mov
After:
2025-01-27.10-13-09.mov
Affected Areas and Manually Tested Areas
Important
Centralizes and standardizes date/time format handling using
DATE_TIME_FORMATS
across the codebase, ensuring consistent format usage.DATE_TIME_FORMATS
constant inconstants/dateTimeFormats.ts
for centralized date/time formats.convert24hTo12h
utility function for converting 24-hour formats to 12-hour.CustomTimePicker.tsx
,RangePickerModal.tsx
, andGraph/index.tsx
to useDATE_TIME_FORMATS
.DATE_TIME_FORMATS
inLogs/ListLogView/index.tsx
,Logs/RawLogView/index.tsx
, andLogs/TableView/useTableView.tsx
.TraceTable/index.tsx
andTraceDetail/index.tsx
to use standardized formats.useTimezoneFormatter.ts
to useDATE_TIME_FORMATS
for default format.tooltipPlugin.ts
andgetAxes.ts
to incorporate new format constants.IntegrationDetailHeader.tsx
andSaveView/index.tsx
for format consistency.This description was created by
for a5892ea. It will automatically update as commits are pushed.