Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(license): license cleanup | query service | frontend #6971

Merged
merged 2 commits into from
Jan 29, 2025

Conversation

vikrantgupta25
Copy link
Member

@vikrantgupta25 vikrantgupta25 commented Jan 29, 2025

Summary

  • remove the older license endpoints and their handlers
  • migrate the frontend to the v3 endpoints for both list and apply

Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added the chore label Jan 29, 2025
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@vikrantgupta25
Copy link
Member Author

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to c7c7235 in 1 minute and 33 seconds

More details
  • Looked at 127 lines of code in 4 files
  • Skipped 0 files when reviewing.
  • Skipped posting 3 drafted comments based on config settings.
1. frontend/src/api/licenses/getAll.ts:1
  • Draft comment:
    Ensure that the API endpoint '/licenses' is correctly handled by the ApiV3Instance, as the backend has removed v2 routes and is using v3 routes.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The change from ApiV2Instance to ApiV3Instance in the import statement aligns with the backend changes where v2 routes were removed and v3 routes are being used. This ensures consistency between the frontend and backend API versions.
2. frontend/src/api/licenses/apply.ts:1
  • Draft comment:
    Ensure that the API endpoint '/licenses' is correctly handled by the ApiV3Instance, as the backend has removed v2 routes and is using v3 routes.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The change from ApiV2Instance to ApiV3Instance in the import statement aligns with the backend changes where v2 routes were removed and v3 routes are being used. This ensures consistency between the frontend and backend API versions.
3. frontend/src/api/licenses/apply.ts:1
  • Draft comment:
    Avoid using the component/index.tsx file structure approach, as it makes it difficult to debug and find components using global search tools like VS Code. This is applicable in other similar files as well.
  • Reason this comment was not posted:
    Comment was on unchanged code.

Workflow ID: wflow_a8a6PuWglRB2nuDO


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@vikrantgupta25 vikrantgupta25 changed the title chore(license): license cleanup chore(license): license cleanup | query service | frontend Jan 29, 2025
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

1 similar comment
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@vikrantgupta25 vikrantgupta25 merged commit cc9eb32 into main Jan 29, 2025
15 of 16 checks passed
@vikrantgupta25 vikrantgupta25 deleted the chore/license-cleanup-ctd branch January 29, 2025 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants