-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(license): license cleanup | query service | frontend #6971
Conversation
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
contributes to - https://github.com/SigNoz/platform-pod/issues/343 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to c7c7235 in 1 minute and 33 seconds
More details
- Looked at
127
lines of code in4
files - Skipped
0
files when reviewing. - Skipped posting
3
drafted comments based on config settings.
1. frontend/src/api/licenses/getAll.ts:1
- Draft comment:
Ensure that the API endpoint '/licenses' is correctly handled by the ApiV3Instance, as the backend has removed v2 routes and is using v3 routes. - Reason this comment was not posted:
Confidence changes required:50%
The change from ApiV2Instance to ApiV3Instance in the import statement aligns with the backend changes where v2 routes were removed and v3 routes are being used. This ensures consistency between the frontend and backend API versions.
2. frontend/src/api/licenses/apply.ts:1
- Draft comment:
Ensure that the API endpoint '/licenses' is correctly handled by the ApiV3Instance, as the backend has removed v2 routes and is using v3 routes. - Reason this comment was not posted:
Confidence changes required:50%
The change from ApiV2Instance to ApiV3Instance in the import statement aligns with the backend changes where v2 routes were removed and v3 routes are being used. This ensures consistency between the frontend and backend API versions.
3. frontend/src/api/licenses/apply.ts:1
- Draft comment:
Avoid using thecomponent/index.tsx
file structure approach, as it makes it difficult to debug and find components using global search tools like VS Code. This is applicable in other similar files as well. - Reason this comment was not posted:
Comment was on unchanged code.
Workflow ID: wflow_a8a6PuWglRB2nuDO
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
1 similar comment
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
Summary
v3
endpoints for bothlist
andapply