-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature]: Mattocks #1119
Draft
SigmundGranaas
wants to merge
48
commits into
1.20
Choose a base branch
from
version/0-13-mattickation
base: 1.20
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[Feature]: Mattocks #1119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a deprecated module. This module is currently still activated instantly so people dont actually lose their progress. It can be deactivitated using the following pack names in the settings file: "forgero:extended-handles-deprecated", "forgero:extended-swords-deprecated", "forgero:extended-tools-deprecated", "forgero:material-deprecated", "forgero:trinkets-deprecated" With this module certain things have been moved to deprecated and we do not suggest using this: - refined/mastercrafted handle variants - polar bear / enderdragon scale - alot of old extended stuff - old gems have been remade Couple of things to note are: Some extended stuff is still broken but merging should be fine if we fix (throwing, reach) Gems should be fully good to go Do we want to activate this when starting or actually deactivate? --------- Co-authored-by: sigmund <sigmundsgranaas@gmail.com> Co-authored-by: Sigmund Granaas Sandring <46557903+SigmundGranaas@users.noreply.github.com>
Converts spears, maces, warhammers and clubs to the new weapon types
Co-authored-by: jorisdebeer <jorisvkeulen@gmail.com>
Implements Swordlike, spear and Blunt weapon as different weapon types. * War hammer is the default for blunt weapons * Spear is the default for spear * Knife is the default for sword_like We could add clubs into the blunt weapon. Tridents will probably also be grouped into the spears type. The type system with defaulted weapons needs to be reworked. It is clearly pushed to the limits now, and the process for selecting which items should be the defaults is just horrible to work with. Check out the weapons by writing: `/forgero extended_hall`
SigmundGranaas
added a commit
that referenced
this pull request
Nov 23, 2024
## Weapons A lot of cool new weapons have been added, new weapon types such as spears and clubs are also added. The new weapons each have a distinct purpose and are more historically accurate. They also look a lot better! ### Cutlass * Significantly higher attack damage and durability compared. * Lower attack speed  ### Rapier * Slightly higher damage * Significantly faster * Extra reach  ### Katana * Faster * Higher damage * More durability  ### Club * Wooden only * High damage * Medium speed * High durability, but limited by material durability * No guard or binding  ### Spear * Significantly higher damage * Medium speed * Significantly improved reach * No guard or binding * Can be thrown  ### Sickle * Lower attack damage * Higher speed * Breaks multiple plants  ### War Hammer * Significantly higher attack damage * Significantly increased durability * Significantly lower speed * **Need to fix model** ### Knife * Lower damage * Lower reach * Significantly faster  ### Kunai * Lower reach * Significantly faster * Can be thrown  ### Mace * Significantly higher attack damage * Significantly increased durability * Significantly lower speed  ### Battle axe * Significantly higher attack damage * Significantly increased durability * Significantly lower speed  ### Broadsword * Higher attack damage * Increased durability * Lower speed  ## Multi block tools The available multi-block tools have been reworked and renamed to be easier to understand and to provide simpler, yet more useful features. ### Hammer * Mines all blocks in a 3x3 pattern * The mining speed is the total mining speed of all the blocks combined  ### Mandrill pickaxe * Vein mines ores * Mines a total of 8 ores in a radius * The mining speed is the total mining speed of all the blocks combined  ### Felling axe * Mines all wooden blocks in a straight column to a maximum of 30 blocks * The mining speed is the total mining speed of all the blocks combined  ### Scythe * Breaks all plant in a radius * The mining speed is instant  ### Spade * Mines all blocks in a 3x3 pattern * The mining speed is the total mining speed of all the blocks combined  ### Entrenching shovel * Mines all blocks in a 2x1 pattern * The mining speed is the total mining speed of all the blocks combined  ## New sword guards All sword guards have been reworked. The new ones a visually distinct, and has some minor variations on durability and weight. All guards have slots for reinforcements and gems. Guards can be placed on all normal sword variants, except knives. ### Tsuba  ### Mechanized  ### Shell  ### Swept  ### Rounded  ### Cruciform  ### Half basket  ## Finding new tools and weapons You can find these new tools and weapons in various locations. Tools and schematics can be found in various loot chests around the world. The wandering trades has a good chance of spawning with every single schematics from this update, so if you want to find them all, the Wandering trader is your best bet. ### Example loot from a weaponsmith villager chest  ### Example trades from a wandering trader  ## Throwing mechanic Some items, like Kunai and spears can now be thrown! By holding the use button, you will throw the item, similarly to how you would throw a trident. The weapons throwing range will be determined by the initial speed and weight of the weapon. It can be picked from the ground and will drop as an item upon hitting an entity. https://github.com/user-attachments/assets/6a9302b4-c30b-40b8-baa1-5319f4bcf6f0 ## Upgradeable items A lot of items are now using the Feature system to add new interactions and behaviours to items. These items can be used in a variety of different tool slots. Upgrading tools and weapons  Upgrading arrows. (This will be enhanced later to make it easier to bulk upgrade arrows.)  ### Fermented spider eye * Applies poison to enemies hit ### Blaze rod * Sets enemies on fire when hit ### Fire charge * Sets enemies on fire when hit ### Magma cream * Sets enemies on fire when hit ### Popped chorus fruit * Teleports enemies when hit ### Nautilus shell * Enhanced damage while in water ### Shulker shell * Applies floating to enemies when hitting them ### Honeycomb * Applies slowness to enemies when hitting them ### Slime ball * Applies knockback to enemies when hitting them ### End crystal * Explodes when hitting an enemy or a block ### Phantom membrane * Applies slow falling to enemies when hitting them ### Copper * Copper has a constant magnetic effect ## New gems The new gem system is a lot simpler and focused. Gems are based on available minerals, and provide simple attribute improvements. Each gem has five levels, where the bonus increases every level. All gems follow a similar upgrade path. ### Obtaining gems Obtaining a level 1 gem is currently based on a very low drop chance from mining the mineral ore. Gems that does not have a corresponding ore, can be found in relevant chests. ### Using gems All bindings and guards have a slot for gems. This means that tools and weapons which have room for a binding or a sword guard can have a single gem. Upgrading bindings with gems can be done in the upgrade station.  ### Upgrading gems All gems use the same upgrade path between levels. Gems is considered to be end-game features, and reaching higher gem levels require you to progress through the game. Level 1 -> Level 2: Crafted by surrounding the gem in amethyst shards. Level 2 -> Level 3: Stone cutting the level 2 gem Level 3 -> Level 4: Combine level 3 gem and dragons breath. Level 4 -> Level 5: Combine level 4 gem and a nether star. ### Amethyst gem  Attribute bonus: **Mining level** Bonus per level: * 1: +1 * 2: +2 * 3: +3 * 4: +4 * 5: +5 ### Diamond gem  Attribute bonus: **Durability** Bonus per level: * 1: +250 * 2: +750 * 3: +1250 * 4: +1750 * 5: +2250 ### Echo gem  Attribute bonus: **Mining Speed** Bonus per level: * 1: +1 * 2: +2 * 3: +3 * 4: +4 * 5: +5 ### Emerald gem  Attribute bonus: **Attack Speed** Bonus per level: * 1: +0.15 * 2: +0.3 * 3: +0.45 * 4: +0.6 * 5: +0.75 ### Lapiz Lazuli gem  Attribute bonus: **Reach** Bonus per level: * 1: +0.5 * 2: +1 * 3: +1.5 * 4: +2 * 5: +2.5 ### Prismarine gem  Attribute bonus: **Attack Damage** Bonus per level: * 1: +1 * 2: +2 * 3: +3 * 4: +4 * 5: +5 ### Quartz gem  Attribute bonus: **Armor** Bonus per level: * 1: +1 * 2: +2 * 3: +3 * 4: +4 * 5: +5 ## Commands Extended weapons: `forgero extended_hall` Multi block tools: `forgero multi_block` ## Upcoming 0.13 content Not everything was ready for the initial 0.13 release, so we had to delay some new features and items to get the update out of the door a bit quicker. ### Crossbows Crossbows are in the works, and makes it possible to craft custom crossbow limbs and stocks. These will be available in Wood and metals variants and can be combined to create a wide range of crossbow configurations. It is going to work similarly to vanilla crossbows, so they will be slow to load, will retain a loaded arrow and packs a real punch. #1100 ### Tridents Support for tridents is also in the works. Tridents will be almost identical to the vanilla trident, but will be available in all materials. Trident enchantments will also be supported. #1101 ### Mattocks Mattocks were initially slated for the 0.13 release, but is now going to be a dedicated release due to the work required to get it ready. #1119 ## Changes A lot of stuff has been removed or discarded to better align and balance the mod. The stuff that has been removed has either been poorly implemented, reworked in this released or was just not ready for release yet. Here is a full overview. ### Conditions on tools have been disabled Due to the unstable nature and lack of clear direction for the conditions on tools, they have currently been disabled. Parts and schematics looted from chests and other location no longer have a chance of getting random conditions. This feature has been disabled until we can rework it. Existing conditions on parts and schematics will still work, but you will not be able to find new ones. ### Deprecated packages Several items from the extended package are now outdated, as they have either been reworked, discarded or replaced. This means they are no longer included by default with Forgero and will be permanently removed in an upcoming release. Probably Forgero - 0.14. To make it easier to upgrade and test this new release these packages have been moved into a dedicated module. #### How to upgrade If you are scared of loosing items, it is always a good idea to back up your save game before updating to the latest major version of this mod. If you have previously used Forgero in your game instance, there will already be a generated config file, which means that the deprecated packages will be loaded as normal when upgrading. No items will be deleted in this case, and you can use the old tools, weapons and gems as before, including the new ones. It is recommended to remove the forgero_settings.json file from the config directory and restart the game. This will disable the deprecated package by default and you will only have the new tools and weapons. When starting the mod for the first time, this will be the default behaviour. As an alternative, you can add this to the forgero_settings.json file. This will make sure all deprecated packs are disabled. ```json "disabledPacks": [ "forgero:extended-handles-deprecated", "forgero:extended-swords-deprecated", "forgero:extended-tools-deprecated", "forgero:material-deprecated", "forgero:trinkets-deprecated" ], ``` #### Deprecated items * Mastercrafted and refined handles * All previous multi-block tools * Ore mining pickaxe * Tree feller axe * Chopper axe * Path mining pickaxe * Grave digger shovel * Path digger shovel * Reaper * All previous gems * Magnetico * Diamond * Redstone * Lapiz * Undying totem * Stone heart * Blazed stone heart * Ender gem * Quartz * Lightweight pickaxe head * Battle axe (Old) * Saber * Scimitar * Slanted sword * Serrated sword * Shortsword * Old Sword guards * Agile * Duelling * Kimiri * tsuba * Materials * Dragon scale * Polar bear pelt --------- Co-authored-by: JorisDeBeer <115664543+JorisDeBeer@users.noreply.github.com> Co-authored-by: jorisdebeer <jorisvkeulen@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds mattock variants and upgradeable heads for all vanilla tool variants