[Compat]: BetterEnd compatibility #957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ungus. Oops again.
Better End Compatibility has been added.
# Conflicts: # fabric/forgero-fabric-compat/build.gradle # fabric/forgero-fabric-compat/gradle.properties
[Feature]: Some necessary changes for BetterEnd
[Feature]: 6 materials added for BetterEnd.
Steveplays28
changed the title
Steveplays28
added
new feature
SigmundGranaas
changed the title
SigmundGranaas
requested changes
Jul 26, 2024
There was a problem hiding this comment.
Awesome work! This is really well done. All the comments are just smaller things that should be fixed, but it is not critical.
The comments are just about removing attributes that cannot be applied in any configuration at the moment. I have probably missed some attributes, so it would probably be nice to go through again and see if we missed any.
Other that that, this seems good to go!
...forgero-compat/src/main/resources/data/forgero/packs/betterend/material/eternal_crystal.json
Show resolved
Hide resolved
content/forgero-compat/src/main/resources/data/forgero/packs/betterend/material/gelatine.json
Show resolved
Hide resolved
...nt/forgero-compat/src/main/resources/data/forgero/packs/betterend/material/lumecorn_rod.json
Show resolved
Hide resolved
...ero-compat/src/main/resources/data/forgero/packs/betterend/material/raw_chorus_mushroom.json
Show resolved
Hide resolved
content/forgero-compat/src/main/resources/data/forgero/packs/betterend/material/silk_fiber.json
Show resolved
Hide resolved
...forgero-compat/src/main/resources/data/forgero/packs/betterend/material/sulphur_crystal.json
Show resolved
Hide resolved
content/forgero-compat/src/main/resources/assets/forgero/lang/en_us.json
Outdated
Show resolved
Hide resolved
content/forgero-compat/src/main/resources/data/forgero/packs/betterend/material/umbralith.json
Outdated
Show resolved
Hide resolved
SigmundGranaas
changed the title
SigmundGranaas
added a commit
that referenced
this pull request
Sep 12, 2024
All thanks to our new buddy in the Discord. Balancing is a work in progress but its so big I checked it through didnt seem anything off. I will probably play with this mod anyway soon so should be fine --------- Co-authored-by: Apocip0 <apostolciprian1000@gmail.com> Co-authored-by: Sigmund Granaas Sandring <46557903+SigmundGranaas@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All thanks to our new buddy in the Discord.
Balancing is a work in progress but its so big I checked it through didnt seem anything off. I will probably play with this mod anyway soon so should be fine