Invert displayMultiplier and displayOffset semantics

SignalK · Sep 26, 2024 · c482a57 · c482a57
1 parent 4d4ff35
commit c482a57
Show file tree

Hide file tree

Showing 2 changed files with 1,947 additions and 1,948 deletions.
diff --git a/frontend/src/pages/Configuration/ConfigCard.tsx b/frontend/src/pages/Configuration/ConfigCard.tsx
@@ -68,14 +68,14 @@ export function EditControl({
           key={id}
           label={schema.title}
           value={
-            (Number(value) - (schema.displayOffset ?? 0)) /
-            (schema.displayMultiplier ?? 1)
+            (schema.displayMultiplier ?? 1) * Number(value) +
+            (schema.displayOffset ?? 0)
           }
           readOnly={schema.readOnly ?? false}
           setValue={(value: number) => {
             setValue(
-              value * (schema.displayMultiplier ?? 1) +
-                (schema.displayOffset ?? 0),
+              (value - (schema.displayOffset ?? 0)) /
+                (schema.displayMultiplier ?? 1),
             );
           }}
         />
@@ -86,15 +86,15 @@ export function EditControl({
           key={id}
           label={schema.title}
           value={
-            Number(value) * (schema.displayMultiplier ?? 1) +
+            (schema.displayMultiplier ?? 1) * Number(value) +
             (schema.displayOffset ?? 0)
           }
           readOnly={schema.readOnly ?? false}
           step={1}
           setValue={(value: number) => {
             setValue(
-              value / (schema.displayMultiplier ?? 1) -
-                (schema.displayOffset ?? 0),
+              (value - (schema.displayOffset ?? 0)) /
+                (schema.displayMultiplier ?? 1),
             );
           }}
         />