Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BME280, SensESP fails to start if sensor not present #151

Closed
KEGustafsson opened this issue Aug 26, 2020 · 2 comments
Closed

BME280, SensESP fails to start if sensor not present #151

KEGustafsson opened this issue Aug 26, 2020 · 2 comments

Comments

@KEGustafsson
Copy link
Contributor

If BME280 device is not present then SensESP startup fails and device is halted.
␛[0m(I) (check_status) Could not find a valid BME280 sensor. Check wiring, address, and sensor ID. ␛[0m(I) (check_status) SensorID is: 0x255 ␛[0m(I) (check_status) 0xFF: is a BMP180 or BMP085, or a bad address ␛[0m(I) (check_status) 0x56-0x58 is a BMP280 ␛[0m(I) (check_status) 0x60 is a BME280 ␛[0m(I) (check_status) 0x61 is a BME680 ␛[0m
Log reporting stops here.

Program stops here.
https://github.com/SignalK/SensESP/blob/master/src/sensors/bme280.cpp#L27

Would be much better to catch the issue internally and just disable reading the values for the sensor and allow the rest of the program to continue.

@BjarneBitscrambler
Copy link
Contributor

This behaviour will also happen using the orientation sensor I've been working on ( #145 ). I'll have a look at my code and see about fixing it - I agree that a system that potentially has dozens of sensors should degrade gracefully if any one of the sensors fails.

@ba58smith
Copy link
Collaborator

@BjarneBitscrambler - I've fixed this behavior for the BME280 sensor with PR #158. I'll leave it up to you to create an issue for your magnetometer sensor, or just fix it in another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants