-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BME280 sensor with example #96
Conversation
Looks really good except for the two comments! |
If BME280 device is not present or broken then SensESP startup fails and device is halted. Is this needed? |
I'd say that's harmful. Would be much better to catch the issue internally and just disable reading the values for the sensor and allow the rest of the program to continue. Recommend opening an issue, though. Discussions in already merged PRs are quite difficult to find for most people. :-) |
I'll do that and I'll copy your comment as an option to overcome the issue. |
Per a request from someone on Slack. Issue #96 .