Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use mDNS always unless a server has been configured #636

Merged
merged 2 commits into from
Feb 14, 2023
Merged

Use mDNS always unless a server has been configured #636

merged 2 commits into from
Feb 14, 2023

Conversation

mairas
Copy link
Collaborator

@mairas mairas commented Jan 19, 2023 •
edited
Loading

The WSClient persistence logic now follows the rest of the codebase (I think...):

  • If nothing is configured, mDNS is always used.
  • If a server is hardcoded, it is used by default.
  • If the server address is set through the config page, that address is used.
  • If the server address is cleared through the config page, mDNS is used.

Fixes #634.

@mairas mairas mentioned this pull request Jan 19, 2023
Closed
johannbarbie
johannbarbie approved these changes Jan 28, 2023
View reviewed changes
Copy link

@johannbarbie johannbarbie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

state logic of connect() easier to follow without the additional local variables.

@mairas
Copy link
Collaborator Author

mairas commented Feb 14, 2023

Seems like I forgot to merge this... Oops!

@mairas mairas merged commit 0203ca0 into main Feb 14, 2023
@mairas mairas deleted the mdns_always branch February 14, 2023 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johannbarbie johannbarbie johannbarbie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SensESP stuck on old IP when SignalK changes IP
2 participants
@mairas @johannbarbie