Fix clang-tidy warnings #737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mairas
force-pushed
the
clang-tidy
branch
2 times, most recently
from
7267753
to
5bce052
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran clang-tidy against the SensESP codebase and fixed (most of) the issues. While this overall results in improved code quality and consistency, there are some breaking changes as well. In particular, the
reactespnamespace was imported in one of the header files, which is a major no-no. (Didn't realize it at the time.) I've removed theusingdeclaration and as a result,reactespneeds to be explicitly stated when referring toReactESPandReactionclasses. This doesn't have a huge impact on simpler end user code because they can always import the namespace but it's a breaking change, nevertheless.