Configpath msgs #79
Merged
Configpath msgs #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Somehow I got this PR jumbled up with the previous one. They're both simple, so hopefully both can just be merged with no problems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the debug message for
Configurable::load_configuration()specific to the cause of the message (no config path was specified, or no file was found in SPIFFS).I did this because I often saw one or the other of these messages in the Serial Monitor that didn't make sense, so I wanted to make sure I understood the message. Now that I've done that, I've uncovered what I think is a bug: the error message that results from
if (!SPIFFS.exists(config_path))happens for many sensors and transports when it doesn't appear to be correct. See Issue #88 .