Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package issues (error reporting, timestamp, Swagger bugs) #1408

Open
susanodd opened this issue Dec 2, 2024 · 4 comments
Open

Package issues (error reporting, timestamp, Swagger bugs) #1408

susanodd opened this issue Dec 2, 2024 · 4 comments
Assignees

Comments

@susanodd
Copy link
Collaborator

susanodd commented Dec 2, 2024

Revised issue:

The Swagger package URL Python code does not account for errors in the input of the request. There are no guarded clauses and no appropriate response code for any errors.

Fix the broken Swagger endpoints that "don't work". Return HttpResponseBadRequest responses instead of server errors visible in the Swagger server feedback panel.

Original issue

The package may be reporting too many signs as having been "changed" when use is made of the timestamp.

We kind of need a "per field update" not the entire contents of the gloss. The timestamp could be modified to look in the revision history and only return fields that have been modified.

(See #1368 )

It's kind of like if the API is checking the package for updates, but those updates are from a request from the API itself, then the API was the one changing the gloss. So it's going to get stuck in a loop. Is the Time Zone correct on Signbank?

@susanodd susanodd changed the title Package doesn't work on Swagger Package issues (timestamp, doesn't work on Swagger) Dec 6, 2024
@susanodd susanodd changed the title Package issues (timestamp, doesn't work on Swagger) Package issues (timestamp not precise enough, package url doesn't work on Swagger) Dec 6, 2024
@Woseseltops Woseseltops removed their assignment Jan 9, 2025
@susanodd susanodd self-assigned this Jan 16, 2025
@susanodd

This comment has been minimized.

@susanodd susanodd removed their assignment Jan 22, 2025
@susanodd

This comment has been minimized.

@susanodd susanodd self-assigned this Jan 23, 2025
@susanodd susanodd changed the title Package issues (timestamp not precise enough, package url doesn't work on Swagger) Package issues (error reporting, timestamp not precise enough, Swagger) Jan 23, 2025
@susanodd susanodd changed the title Package issues (error reporting, timestamp not precise enough, Swagger) Package issues (error reporting, timestamp, Swagger bugs) Jan 23, 2025
@susanodd
Copy link
Collaborator Author

susanodd commented Jan 23, 2025

NOTE TO SELF

What do we want to happen if the user is anonymous? At the moment, this defaults to NGT if no dataset acronym is in the request.
Do we want a bad request or to default to NGT? (It seems kind of inconsistent to default to NGT.)

I'm going to make it be errors if the user does not provide information.

@susanodd
Copy link
Collaborator Author

@Woseseltops I remembered what the question is, is the "package" supposed to use the API token? It takes its arguments in the url as GET format

susanodd pushed a commit that referenced this issue Jan 23, 2025
…cated

otherwise for anonymous returns datasets with public glosses
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants