-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package issues (error reporting, timestamp, Swagger bugs) #1408
Comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
NOTE TO SELF What do we want to happen if the user is anonymous? At the moment, this defaults to NGT if no dataset acronym is in the request. I'm going to make it be errors if the user does not provide information. |
@Woseseltops I remembered what the question is, is the "package" supposed to use the API token? It takes its arguments in the url as GET format |
…cated otherwise for anonymous returns datasets with public glosses
Revised issue:
The Swagger package URL Python code does not account for errors in the input of the request. There are no guarded clauses and no appropriate response code for any errors.
Fix the broken Swagger endpoints that "don't work". Return HttpResponseBadRequest responses instead of server errors visible in the Swagger server feedback panel.
Original issue
The package may be reporting too many signs as having been "changed" when use is made of the timestamp.
We kind of need a "per field update" not the entire contents of the gloss. The timestamp could be modified to look in the revision history and only return fields that have been modified.
(See #1368 )
It's kind of like if the API is checking the package for updates, but those updates are from a request from the API itself, then the API was the one changing the gloss. So it's going to get stuck in a loop. Is the Time Zone correct on Signbank?
The text was updated successfully, but these errors were encountered: