Fix list_agents to return string instead of JSON object #1471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nponeccop
previously approved these changes
Apr 15, 2023
harrymunro
reviewed
Apr 15, 2023
harrymunro
previously approved these changes
Apr 15, 2023
|
@gersh There are conflicts now |
Stefben46
previously approved these changes
Apr 15, 2023
gersh
changed the title
nponeccop
approved these changes
Apr 15, 2023
richbeales
approved these changes
Apr 15, 2023
sindlinger
pushed a commit
to Orgsindlinger/Auto-GPT-WebUI
that referenced
this pull request
Sep 25, 2024
Fix list_agents to return string instead of JSON object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
list_agents was calling itself and encountering infinite recursion. Now, that has been fixed, but it is still returning a JSON array instead of a string, which I believe is a bug.
Changes
Make list_agents return a string with info on the user agents.
Documentation
Test Plan
I added a unit test to test that list_agents works.
PR Quality Checklist