Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove least relevant items from memory first #1825

Merged
merged 1 commit into from
Apr 16, 2023
Merged

Remove least relevant items from memory first #1825

merged 1 commit into from
Apr 16, 2023

Conversation

farizrahman4u
Copy link
Contributor

@farizrahman4u farizrahman4u commented Apr 16, 2023 •
edited
Loading

Background

Local memory returns documents in descending order of scores, so relevant memory should be popped from right to fit token limit.

Changes

Pop relevant memory from right instead of left.

Documentation

Test Plan

PR Quality Checklist

  • [ .] My pull request is atomic and focuses on a single change.
  • [ .] I have thoroughly tested my changes with multiple different prompts.
  • [ .] I have considered potential risks and mitigations for my changes.
  • [ .] I have documented my changes clearly and comprehensively.
  • [ .] I have not snuck in any "extra" small tweaks changes

@BillSchumacher BillSchumacher merged commit 19d2aa5 into Significant-Gravitas:master Apr 16, 2023
sindlinger pushed a commit to Orgsindlinger/Auto-GPT-WebUI that referenced this pull request Sep 25, 2024
@BillSchumacher
Merge pull request Significant-Gravitas#1825 from farizrahman4u/patch-3
65c6224 
Remove least relevant items from memory first
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillSchumacher BillSchumacher BillSchumacher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@farizrahman4u @BillSchumacher