Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for agent and agent manager #3002

Closed
wants to merge 44 commits into from

Conversation

rihp
Copy link
Contributor

@rihp rihp commented Apr 23, 2023

Background

Changes

Documentation

Test Plan

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes

waynehamadi and others added 30 commits April 22, 2023 05:52
Signed-off-by: Merwane Hamadi <merwanehamadi@gmail.com>
Signed-off-by: Merwane Hamadi <merwanehamadi@gmail.com>
…re/create-smoke-test

Feature/create smoke test
…e-plugins

Enable support for loading multiple plugins per zip file
…s/richbeales-patch-1

Plugins: debug line always printed in plugin load
Signed-off-by: Merwane Hamadi <merwanehamadi@gmail.com>
Signed-off-by: Merwane Hamadi <merwanehamadi@gmail.com>
…re/add-decorator-to-tests

add decorator to tests so it's skipped if api key required but not present in the environment
@codecov
Copy link

codecov bot commented Apr 23, 2023

Codecov Report

Patch coverage has no change and project coverage change: -9.44 ⚠️

Comparison is base (794a164) 49.40% compared to head (d921c2d) 39.96%.

❗ Current head d921c2d differs from pull request most recent head c6f4aa8. Consider uploading reports for the commit c6f4aa8 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3002      +/-   ##
==========================================
- Coverage   49.40%   39.96%   -9.44%     
==========================================
  Files          63       60       -3     
  Lines        3004     2890     -114     
  Branches      494      475      -19     
==========================================
- Hits         1484     1155     -329     
- Misses       1400     1660     +260     
+ Partials      120       75      -45     

see 33 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ntindle
Copy link
Member

ntindle commented Apr 23, 2023

Related #368

@rihp
Copy link
Contributor Author

rihp commented Apr 24, 2023

closing in favor of #3116

@rihp rihp closed this Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants