Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix test_search_files for windows #3073

Merged

Conversation

k-boikov
Copy link
Contributor

Background

image
Test fails on Windows due to windows directory separator.

Changes

Use os.path.join instead of hardcoded slash.

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes

@k-boikov k-boikov added bug Something isn't working one-liner testing and removed size/xs labels Apr 24, 2023
@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Patch coverage has no change and project coverage change: -8.06 ⚠️

Comparison is base (e8473d4) 49.40% compared to head (9ade87d) 41.34%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3073      +/-   ##
==========================================
- Coverage   49.40%   41.34%   -8.06%     
==========================================
  Files          63       63              
  Lines        3004     3004              
  Branches      494      494              
==========================================
- Hits         1484     1242     -242     
- Misses       1400     1697     +297     
+ Partials      120       65      -55     

see 14 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@richbeales richbeales merged commit 3886afc into Significant-Gravitas:master Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants