Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dead permanent memory module #3145

Merged
merged 6 commits into from
Apr 24, 2023
Merged

Remove dead permanent memory module #3145

merged 6 commits into from
Apr 24, 2023

Conversation

collijk
Copy link
Contributor

@collijk collijk commented Apr 24, 2023 •
edited
Loading

Background

This module is not used anywhere in the codebase but has import time side effects (it makes a sqlite db that it never cleans up in the main repo directory).

Pitfalls of having this code in the codebase:

  • It is confusing for developers trying to understand how memory works in the system.
  • It has import-time side effects that cause the creation of sqlite dbs in random repository directories when pytest is run locally. These things can (and will) get picked up by git at some point.
  • It is bad practice to keep unused code around because "we might want to use it". It is technical debt in the repo. It's a bad precedent for other contributors. It also ignores the fact that we have tools to reference this code later.

Changes

Remove the permanent_memory module and the corresponding test.

Documentation

N/A

Test Plan

N/A

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes

@codecov
Copy link

codecov bot commented Apr 24, 2023 •
edited
Loading

Codecov Report

Patch coverage has no change and project coverage change: -9.32 ⚠️

Comparison is base (b984f98) 50.28% compared to head (2182271) 40.96%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3145      +/-   ##
==========================================
- Coverage   50.28%   40.96%   -9.32%     
==========================================
  Files          65       64       -1     
  Lines        3029     2944      -85     
  Branches      507      497      -10     
==========================================
- Hits         1523     1206     -317     
- Misses       1378     1679     +301     
+ Partials      128       59      -69

see 15 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@richbeales
Copy link
Contributor

I'd rather we start using it than remove it entirely?

@p-i- p-i- merged commit 83b91a3 into Significant-Gravitas:master Apr 24, 2023
@collijk collijk deleted the feature/remove-dead-permanent-memory-module branch April 24, 2023 22:05
misterak8 added a commit to misterak8/Auto-GPT that referenced this pull request Apr 26, 2023
@misterak8 @Pwuts
@collijk @younessZMZ @ntindle @rihp @waynehamadi @richbeales @BillSchumacher @zhanglei1172 @dychen @johnseth97 @lwneal @gluonhiggs @MarKiSS2000 @Torantulino @AbTrax @ppetermann @psvensson @Androbin
Clean up GitHub Workflows (Significant-Gravitas#3059) (#1)
1fd604d 
* Clean up GitHub Workflows (Significant-Gravitas#3059)

* initial cleanup of github workflows

* only run pr-label workflow on push to master

* move docker ci/release summaries to scripts

* add XS label for PR's under 2 lines

* draft test job for Docker CI

* fix & activate Docker CI test job

* add debug step to docker CI

* fix Docker CI test container env

* Docker CI build matrix

* fixup build summaries

* fix pipes in summary

* optimize Dockerfile for layer caching

* more markdown escaping

* add gha cache scopes

* add Docker CI cache clean workflow

* More robust null byte checking

* Adjust test_json_parser file (Significant-Gravitas#1935)

Co-authored-by: Reinier van der Leer <github@pwuts.nl>

* Add indirection layer between cli and application start

* Agent and agent manager tests (Significant-Gravitas#3116)

* Update Python version and benchmark file in benchmark.yml

* Refactor main function and imports in cli.py

* Update import statement in ai_config.py

* Add set_temperature and set_memory_backend methods in config.py

* Remove unused import in prompt.py

* Add goal oriented tasks workflow

* Added agent_utils to create agent

* added pytest and vcrpy

* added write file cassette

* created goal oriented task write file with cassettes to not pay openai tokens

* solve conflicts

* add ability set azure because github workflow needs it off

* solve conflicts in cli.py

* black because linter fails

* solve conflict

* setup github action to v3

Signed-off-by: Merwane Hamadi <merwanehamadi@gmail.com>

* fix conflicts

Signed-off-by: Merwane Hamadi <merwanehamadi@gmail.com>

* Plugins: debug line always printed in plugin load

* add decorator to tests

Signed-off-by: Merwane Hamadi <merwanehamadi@gmail.com>

* move decorator higher up

Signed-off-by: Merwane Hamadi <merwanehamadi@gmail.com>

* init

* more tests

* passing tests

* skip gitbranch decorator on ci

* decorator skiponci

* black

* Update tests/utils.py decorator of skipping ci

Co-authored-by: Nicholas Tindle <nicktindle@outlook.com>

* black

* I oopsed the name

* black

* finally

* simple tests for agent and manager

* ísort

---------

Signed-off-by: Merwane Hamadi <merwanehamadi@gmail.com>
Co-authored-by: Merwane Hamadi <merwanehamadi@gmail.com>
Co-authored-by: Merwane Hamadi <merwane.hamadi@redica.com>
Co-authored-by: Richard Beales <rich@richbeales.net>
Co-authored-by: Nicholas Tindle <nick@ntindle.com>
Co-authored-by: BillSchumacher <34168009+BillSchumacher@users.noreply.github.com>
Co-authored-by: Nicholas Tindle <nicktindle@outlook.com>

* anontation fix (Significant-Gravitas#3018)

* anontation fix

* fix param name and type

---------

Co-authored-by: Richard Beales <rich@richbeales.net>

* Hotfix/global agent manager workaround (Significant-Gravitas#3157)

* Add indirection layer to entry point

* Get around singleton pattern for AgentManager to fix tests

* Remove dead permanent memory module (Significant-Gravitas#3145)

* Remove dead permanent memory module

* Delete sqlite db that snuck in

* Refactor/move singleton out of config module (Significant-Gravitas#3161)

* Add option to install plugin dependencies (Significant-Gravitas#3068)

Co-authored-by: Nicholas Tindle <nick@ntindle.com>

* Re-add install-plugin-deps to CLI (Significant-Gravitas#3170)

* Update ci.yml (Significant-Gravitas#3179)

* Update bulletin to warn about deprication (Significant-Gravitas#3181)

* Ensure Fore.RED is followed by Fore.RESET (Significant-Gravitas#3182)

This properly resets the terminal, ensuring that the red text is red and
the normal text remains unaffected.

Co-authored-by: Richard Beales <rich@richbeales.net>

* Add a little more descriptive installation instruction (Significant-Gravitas#3180)

* add Dev Container installation instruction to installation.md

* add Dev Container installation instruction to installation.md

* Update installation.md

---------

Co-authored-by: Richard Beales <rich@richbeales.net>

* Update installation.md (Significant-Gravitas#3166)

* Refactor/decouple logger from global configuration (Significant-Gravitas#3171)

* Decouple logging from the global configuration

* Configure logging first

* Clean up global voice engine creation

* Remove class vars from logger

* Remove duplicate implementation of

---------

Co-authored-by: Richard Beales <rich@richbeales.net>

* docs fix to image generation (Significant-Gravitas#3186)

* Update README.md

* Feature: Added Self Feedback (Significant-Gravitas#3013)

* Feature: Added Self Feedback

* minor fix: complied to flake8

* Add: Self Feedback To Usage.md

* Add: role/goal allignment

* Added: warning to usage.md

* fix: Formatted with black

---------

Co-authored-by: Richard Beales <rich@richbeales.net>

* Update README.md

* this changes it so the file from config is used, rather than a hardcoded name that might not exist (Significant-Gravitas#3189)

* Test `Agent.create_agent_feedback` (Significant-Gravitas#3209)

* remove plugin notice from CONTRIBUTING.md (Significant-Gravitas#3227)

* Extract OpenAI API retry handler and unify ADA embeddings calls. (Significant-Gravitas#3191)

* Extract retry logic, unify embedding functions

* Add some docstrings

* Remove embedding creation from API manager

* Add test suite for retry handler

* Make api manager fixture

* Fix typing

* Streamline tests

* Use explicit API keys when querying openai rather than import time manipulation of the package attributes (Significant-Gravitas#3241)

* Fix readme centering (Significant-Gravitas#3243)

* Remove import time loading of config from llm_utils (Significant-Gravitas#3245)

* adding probably erroneously removed return value from execut_shell, giving 'None' in return always otherise - not ideal (Significant-Gravitas#3212)

Co-authored-by: James Collins <collijk@uw.edu>

* Load .env in package init (Significant-Gravitas#3251)

* Fix PR size autolabeler message (Significant-Gravitas#3194)

* Fix `get_ada_embedding` return type (Significant-Gravitas#3263)

---------

Signed-off-by: Merwane Hamadi <merwanehamadi@gmail.com>
Co-authored-by: Reinier van der Leer <github@pwuts.nl>
Co-authored-by: James Collins <collijk@uw.edu>
Co-authored-by: YOUNESS ZEMZGUI <31807902+younessZMZ@users.noreply.github.com>
Co-authored-by: Nicholas Tindle <nick@ntindle.com>
Co-authored-by: Media <12145726+rihp@users.noreply.github.com>
Co-authored-by: Merwane Hamadi <merwanehamadi@gmail.com>
Co-authored-by: Merwane Hamadi <merwane.hamadi@redica.com>
Co-authored-by: Richard Beales <rich@richbeales.net>
Co-authored-by: BillSchumacher <34168009+BillSchumacher@users.noreply.github.com>
Co-authored-by: Nicholas Tindle <nicktindle@outlook.com>
Co-authored-by: Lei Zhang <isleizhang@outlook.com>
Co-authored-by: Daniel Chen <daniel.young.chen@gmail.com>
Co-authored-by: Deso <ethan.johnson1997@outlook.com>
Co-authored-by: Lawrence Neal <lwneal@users.noreply.github.com>
Co-authored-by: Duong HD <79622476+resduo@users.noreply.github.com>
Co-authored-by: ✔️ITtechtor <104917057+MarKiSS2000@users.noreply.github.com>
Co-authored-by: Toran Bruce Richards <toran.richards@gmail.com>
Co-authored-by: AbTrax <45964236+AbTrax@users.noreply.github.com>
Co-authored-by: Peter Petermann <ppetermann80@googlemail.com>
Co-authored-by: Peter Svensson <psvensson@gmail.com>
Co-authored-by: Robin Richtsfeld <robin.richtsfeld@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p-i- p-i- p-i- approved these changes

Assignees
No one assigned
Labels
size/l
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@collijk @richbeales @p-i-