-
Notifications
You must be signed in to change notification settings - Fork 45k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix clone_repository
to conform to URL validation
#3150
Fix clone_repository
to conform to URL validation
#3150
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #3150 +/- ##
==========================================
- Coverage 49.52% 41.00% -8.53%
==========================================
Files 64 64
Lines 2946 2946
Branches 497 497
==========================================
- Hits 1459 1208 -251
- Misses 1365 1679 +314
+ Partials 122 59 -63
... and 15 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! out of curiosity did you actually get an error? i thought that even though it's called url in the wrapper function because that's a positional arg and not a kwarg that it doesn't actually matter what the url argument is called, just that it comes first
b99faba
to
46cb2fb
Compare
Yep, I did! I received an error stating that the positional argument |
46cb2fb
to
e59e396
Compare
Nice, great fix!
On Mon, Apr 24, 2023 at 5:34 PM Steven Baumann ***@***.***> wrote:
lgtm! out of curiosity did you actually get an error? i thought that even
though it's called url in the wrapper function because that's a positional
arg and not a kwarg that it doesn't actually matter what the url argument
is called, just that it comes first
Yep, I did! I received an error stating that the positional argument url
was missing.
—
Reply to this email directly, view it on GitHub
<#3150 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHTWBOBVPZYDNWPKGKYGI7DXC3WW7ANCNFSM6AAAAAAXJ6I53U>
.
You are receiving this because you commented.Message ID:
***@***.***>
--
Eddie Cohen, Software Engineer
Lightmatter <https://lightmatter.com/>
***@***.***
|
6019a55
to
96e2b68
Compare
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #3150 +/- ##
=======================================
Coverage 57.19% 57.19%
=======================================
Files 68 68
Lines 3079 3079
Branches 516 516
=======================================
Hits 1761 1761
Misses 1180 1180
Partials 138 138
☔ View full report in Codecov by Sentry. |
ed39335
to
2540c9f
Compare
8f21e0d
to
67abf1b
Compare
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
67abf1b
to
110a8ba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested and git clone
command is working again. LGTM!
@Pwuts @BillSchumacher
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
If one of you has the time, please also submit a PR adding a test for |
clone_repository
to conform to URL validation
…itas#3150) Co-authored-by: Reinier van der Leer <github@pwuts.nl>
Background
In the most recent change, git clone no longer adheres to the URL validation schema, causing positional argument errors.
Changes
Changed
repository_url
tourl
to adhere to the URL validation schema.Documentation
Updated the function documentation to say
url
instead.Test Plan
Same tests as before.
PR Quality Checklist