Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codecov - don't fail pipelines for project cov changes #3327

Merged
merged 4 commits into from
Apr 26, 2023

Conversation

vlad-ko
Copy link
Contributor

@vlad-ko vlad-ko commented Apr 26, 2023

Background

Adding changes to codecov yaml, based on our chat with the team

Changes

Adding a "patch" coverage setup and instructions for how to setup flags and separate test coverage

Documentation

https://docs.codecov.com/docs/codecovyml-reference

Test Plan

N/A

PR Quality Checklist

  • [ x] My pull request is atomic and focuses on a single change.
  • [ x] I have thoroughly tested my changes with multiple different prompts.
  • [ x] I have considered potential risks and mitigations for my changes.
  • [ x] I have documented my changes clearly and comprehensively.
  • [ x] I have not snuck in any "extra" small tweaks changes

@vercel
Copy link

vercel bot commented Apr 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Apr 26, 2023 2:40pm

ntindle
ntindle previously approved these changes Apr 26, 2023
@ntindle ntindle dismissed their stale review April 26, 2023 14:34

testing

@ntindle
Copy link
Member

ntindle commented Apr 26, 2023

Can you point this into master? We don't run coverage on PRs into other branches

@vlad-ko vlad-ko changed the base branch from codecov-test to master April 26, 2023 14:36
@ntindle
Copy link
Member

ntindle commented Apr 26, 2023

Hmm... our workflows aren't triggered on a base branch change. That's a new one. Really sorry but can you make a new pr or push an empty commit to this one?

@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Patch coverage has no change and project coverage change: -7.88 ⚠️

Comparison is base (749b1bb) 50.73% compared to head (5e19ab7) 42.86%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3327      +/-   ##
==========================================
- Coverage   50.73%   42.86%   -7.88%     
==========================================
  Files          65       65              
  Lines        2935     2935              
  Branches      493      493              
==========================================
- Hits         1489     1258     -231     
- Misses       1326     1615     +289     
+ Partials      120       62      -58     
Impacted Files Coverage Δ
autogpt/memory/base.py 75.00% <ø> (ø)

... and 15 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ntindle ntindle changed the title Codecov test Codecov - don't fail pipelines for project cov changes Apr 26, 2023
@ntindle ntindle merged commit 1e71f95 into Significant-Gravitas:master Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants