Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a regression test for the embedding #3422

Conversation

collijk
Copy link
Contributor

@collijk collijk commented Apr 27, 2023

Background

There are many open issues related to the maximum tokens allowed to be passed to the embedding. This is a quick regression test to formally document the issue.

There are many related PRs and issues:

Changes

Add regression test for attempting to embed a string that's too long.

Documentation

Comments in the test explaining what it's for.

Test Plan

This

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes

@vercel
Copy link

vercel bot commented Apr 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 27, 2023 6:33pm

@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (427b864) 54.83% compared to head (cbda732) 54.83%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3422   +/-   ##
=======================================
  Coverage   54.83%   54.83%           
=======================================
  Files          65       65           
  Lines        3018     3018           
  Branches      508      508           
=======================================
  Hits         1655     1655           
  Misses       1227     1227           
  Partials      136      136           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vercel vercel bot temporarily deployed to Preview April 27, 2023 18:33 Inactive
@collijk collijk merged commit 94dc6f1 into Significant-Gravitas:master Apr 27, 2023
@collijk collijk deleted the testing/add-embedding-regression-test branch April 27, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants