-
Notifications
You must be signed in to change notification settings - Fork 45k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/llm data structs #3486
Feature/llm data structs #3486
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since info about the models and their max context length is now in llm/providers/openai.py
, settings for that can be removed or given better defaults:
https://github.com/Significant-Gravitas/Auto-GPT/blob/3b74d2150e26ec9387e40cf65a75d8a995d8c9f3/autogpt/config/config.py#L36-L38
Yes, that will be done in a separate PR as it will touch a bunch of files. This PR is to make sure people see the data structures and agree with this representation (got positive feedback from @BillSchumacher , @merwanehamadi , and @ntindle on a PR in my own fork yesterday as I was waiting on a merge for this). |
This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request. |
Agreed but separate PR imo |
Pwuts signed off on my comment explaining we would do other file cleanup in an upcoming PR
Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3486 +/- ##
==========================================
+ Coverage 56.95% 57.19% +0.23%
==========================================
Files 67 68 +1
Lines 3048 3079 +31
Branches 509 516 +7
==========================================
+ Hits 1736 1761 +25
- Misses 1174 1180 +6
Partials 138 138
☔ View full report in Codecov by Sentry. |
Background
This PR proposes some data structures for collecting model information and model responses into standard containers. We can then leverage the containers to hide model api specific details into modules that deal specifically with particular providers (code doing this in the next PR).
Changes
Add core abstractions for model information and model responses.
Documentation
Docstrings
Test Plan
N/A. These are data structures with no (well, very little) logic and no current usages.
PR Quality Checklist