Fix file operations logger #3489

bobisme · 2023-04-28T19:59:44Z

Background

When trying to get Auto-GPT to write and improve on a script, the existing behavior which prevents writing to the same file more than once got in the way.

Changes

Duplication checks now constructs a file store state using a checksum for matching.
Writes with different checksums will succeed, but will fail with the same checksum.
Added tests, minor refactoring.

Documentation

Docstrings, tests, concise code.

Test Plan

Unit tests and told Auto-GPT to:

write a hello world program
write tests for the program

it wrote a hello world that prints to console
it wrote tests that tried to import a hello world object that didn't exist
it successfully updated the script to have an importable function
it tried to write the exact same test code as before, but was blocked

This shows both cases of updated text and non-updated text.

PR Quality Checklist

My pull request is atomic and focuses on a single change.
I have thoroughly tested my changes with multiple different prompts.
I have considered potential risks and mitigations for my changes.
I have documented my changes clearly and comprehensively.
I have not snuck in any "extra" small tweaks changes

vercel · 2023-04-28T19:59:48Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
docs	⬜️ Ignored (Inspect)	Visit Preview		May 1, 2023 3:32pm

github-actions · 2023-04-28T20:00:07Z

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

bobisme · 2023-04-28T20:12:02Z

the size of this is mostly due to docstrings and unit tests

tests/unit/test_file_operations.py

autogpt/commands/file_operations.py

github-actions · 2023-04-29T14:47:22Z

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

github-actions · 2023-04-29T15:21:15Z

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

Co-authored-by: Reinier van der Leer <github@pwuts.nl>

github-actions · 2023-04-29T18:44:39Z

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

github-actions · 2023-04-29T20:15:34Z

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

bobisme

changed as requested, please take another look @Pwuts

autogpt/commands/file_operations.py

github-actions · 2023-04-29T20:28:57Z

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

github-actions · 2023-04-30T05:03:17Z

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

autogpt/commands/file_operations.py

github-actions · 2023-05-01T13:22:04Z

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

github-actions · 2023-05-01T13:25:42Z

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

github-actions · 2023-05-01T13:33:39Z

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

github-actions · 2023-05-01T15:28:11Z

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

github-actions · 2023-05-01T15:33:00Z

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

codecov · 2023-05-01T15:33:04Z

Codecov Report

Patch coverage: 80.88% and project coverage change: +0.26 🎉

Comparison is base (9c56b1b) 59.99% compared to head (7fdefe6) 60.26%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3489      +/-   ##
==========================================
+ Coverage   59.99%   60.26%   +0.26%     
==========================================
  Files          69       69              
  Lines        3102     3143      +41     
  Branches      513      525      +12     
==========================================
+ Hits         1861     1894      +33     
- Misses       1110     1116       +6     
- Partials      131      133       +2

Impacted Files	Coverage Δ
autogpt/commands/file_operations.py	`82.94% <80.88%> (-0.78%)`	⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

File op log uses constructed state instead of patterns.

a21e270

github-actions bot added the size/xl label Apr 28, 2023

collijk added needs discussion To be discussed among maintainers function: process text labels Apr 28, 2023

Pwuts mentioned this pull request Apr 29, 2023

Fix problematic check_duplicate_operation and calls #3126

Closed

5 tasks

Pwuts added function: workspace and removed needs discussion To be discussed among maintainers labels Apr 29, 2023

Pwuts requested changes Apr 29, 2023

View reviewed changes

tests/unit/test_file_operations.py Outdated Show resolved Hide resolved

autogpt/commands/file_operations.py Outdated Show resolved Hide resolved

autogpt/commands/file_operations.py Outdated Show resolved Hide resolved

autogpt/commands/file_operations.py Outdated Show resolved Hide resolved

Pwuts added this to the v0.3.0 release milestone Apr 29, 2023

Pwuts changed the title ~~File log uses constructed state and checksums.~~ Fix file operations logger Apr 29, 2023

Pwuts linked an issue Apr 29, 2023 that may be closed by this pull request

File Operations logger breaks incremental edits #1891

Closed

1 task

Merge branch 'master' into state-machine-file-ops

159775c

github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label Apr 29, 2023

use 1-liner checksum from @Pwuts

4976d08

Co-authored-by: Reinier van der Leer <github@pwuts.nl>

bobisme added 3 commits April 29, 2023 16:04

converted pr code from unittest to pytest

e678f95

merged origin/master

1970382

added Operation type

be2a5fe

bobisme commented Apr 29, 2023

View reviewed changes

autogpt/commands/file_operations.py Outdated Show resolved Hide resolved

autogpt/commands/file_operations.py Outdated Show resolved Hide resolved

github-actions bot removed the conflicts Automatically applied to PRs with merge conflicts label Apr 29, 2023

bobisme mentioned this pull request Apr 29, 2023

COMMAND = write_to_file fails if file exists #3514

Closed

1 task

github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label Apr 30, 2023

rocks6 reviewed Apr 30, 2023

View reviewed changes

autogpt/commands/file_operations.py Outdated Show resolved Hide resolved

autogpt/commands/file_operations.py Outdated Show resolved Hide resolved

samuelbutler mentioned this pull request Apr 30, 2023

File Operations logger breaks incremental edits #1891

Closed

1 task

Merge branch 'master' into state-machine-file-ops

b09d535

vercel bot temporarily deployed to Preview May 1, 2023 13:22 Inactive

linting

b77e544

github-actions bot removed the conflicts Automatically applied to PRs with merge conflicts label May 1, 2023

Fix tests

6783375

Pwuts force-pushed the state-machine-file-ops branch from 2f986d2 to 6783375 Compare May 1, 2023 15:32

Merge branch 'master' into state-machine-file-ops

7fdefe6

Pwuts self-requested a review May 1, 2023 15:33

Pwuts approved these changes May 1, 2023

View reviewed changes

Pwuts merged commit 94ec4a4 into Significant-Gravitas:master May 1, 2023

bobisme deleted the state-machine-file-ops branch May 1, 2023 18:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix file operations logger #3489

Fix file operations logger #3489

bobisme commented Apr 28, 2023

vercel bot commented Apr 28, 2023 •

edited

Loading

github-actions bot commented Apr 28, 2023

bobisme commented Apr 28, 2023

github-actions bot commented Apr 29, 2023

github-actions bot commented Apr 29, 2023

github-actions bot commented Apr 29, 2023

github-actions bot commented Apr 29, 2023

bobisme left a comment

github-actions bot commented Apr 29, 2023

github-actions bot commented Apr 30, 2023

github-actions bot commented May 1, 2023

github-actions bot commented May 1, 2023

github-actions bot commented May 1, 2023

github-actions bot commented May 1, 2023

github-actions bot commented May 1, 2023

codecov bot commented May 1, 2023 •

edited

Loading

Fix file operations logger #3489

Fix file operations logger #3489

Conversation

bobisme commented Apr 28, 2023

Background

Changes

Documentation

Test Plan

PR Quality Checklist

vercel bot commented Apr 28, 2023 • edited Loading

github-actions bot commented Apr 28, 2023

bobisme commented Apr 28, 2023

github-actions bot commented Apr 29, 2023

github-actions bot commented Apr 29, 2023

github-actions bot commented Apr 29, 2023

github-actions bot commented Apr 29, 2023

bobisme left a comment

Choose a reason for hiding this comment

github-actions bot commented Apr 29, 2023

github-actions bot commented Apr 30, 2023

github-actions bot commented May 1, 2023

github-actions bot commented May 1, 2023

github-actions bot commented May 1, 2023

github-actions bot commented May 1, 2023

github-actions bot commented May 1, 2023

codecov bot commented May 1, 2023 • edited Loading

Codecov Report

vercel bot commented Apr 28, 2023 •

edited

Loading

codecov bot commented May 1, 2023 •

edited

Loading