Revert "Filtering out ANSI escape codes in printed assistant thoughts" #4860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Significant-Gravitas#4812)" This reverts commit ebe1861. (cherry picked from commit e9ed0a48e72d96289b0b217424b85a01140399e4)
…icant-Gravitas#4810) Co-authored-by: merwanehamadi <merwanehamadi@gmail.com> Co-authored-by: Luke K (pr-0f3t) <2609441+lc0rp@users.noreply.github.com> (cherry picked from commit bafcdce) (cherry picked from commit b69816823c34ac4c2ef141dc8ec195f55636eff6)
|
This PR exceeds the recommended size of 500 lines. Please make sure you are NOT addressing multiple issues with one PR. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## release-v0.4.4 #4860 +/- ##
==================================================
- Coverage 70.81% 70.62% -0.20%
==================================================
Files 69 68 -1
Lines 3358 3336 -22
Branches 545 535 -10
==================================================
- Hits 2378 2356 -22
- Misses 802 803 +1
+ Partials 178 177 -1
☔ View full report in Codecov by Sentry. |
github-actions
bot
added
the
conflicts
|
This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request. |
|
Can you provide some more background on what's going on here? What was wrong with the original PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #4812 and re-applies only the intended security fixes
This reverts commit ebe1861.
(cherry picked from commit e9ed0a48e72d96289b0b217424b85a01140399e4)