Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for streamtape and krakenfiles #270

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pachax001
Copy link

@pachax001 pachax001 commented Aug 18, 2024

Summary by Sourcery

Fix issues in the direct link generator for streamtape and krakenfiles by updating script extraction logic and correcting URL construction.

Bug Fixes:

  • Fix the script extraction logic in the streamtape function to handle an alternative script pattern.
  • Correct the base URL construction in the krakenfiles function to ensure the post URL is properly formed.

Signed-off-by: pachax001 <93702860+pachax001@users.noreply.github.com>
Copy link

sourcery-ai bot commented Aug 18, 2024

Reviewer's Guide by Sourcery

This pull request addresses issues with the streamtape and krakenfiles functions in the direct_link_generator.py file. The changes improve the robustness of link extraction for streamtape and fix the URL construction for krakenfiles. Additionally, the code has been reformatted to improve readability and adhere to Python style guidelines.

File-Level Changes

Files Changes
bot/helper/mirror_utils/download_utils/direct_link_generator.py Enhanced streamtape link extraction by adding an alternative XPath query
bot/helper/mirror_utils/download_utils/direct_link_generator.py Fixed krakenfiles URL construction by prepending 'https://krakenfiles.com' to the post URL
bot/helper/mirror_utils/download_utils/direct_link_generator.py Improved error handling and error messages in both streamtape and krakenfiles functions
bot/helper/mirror_utils/download_utils/direct_link_generator.py Reformatted code to improve readability and adhere to Python style guidelines

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @pachax001 - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant