Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate LiveViewWindow from SilkyFowl.Avalonia.FuncUI.LiveView. #25

Closed
Tracked by #4
, #27
...
SilkyFowl opened this issue Aug 29, 2023 · 0 comments · Fixed by #26
Closed
Tracked by #4
, #27
...

Separate LiveViewWindow from SilkyFowl.Avalonia.FuncUI.LiveView. #25

SilkyFowl opened this issue Aug 29, 2023 · 0 comments · Fixed by #26
Assignees
@SilkyFowl
Labels
enhancement New feature or request

Comments

@SilkyFowl
Copy link
Owner

SilkyFowl commented Aug 29, 2023 •
edited
Loading

SilkyFowl.Avalonia.FuncUI.LiveView contains a LiveViewWindow that previews a function with a LivePreviewAttribute. Because of this, a dependency of LiveViewWindow, which is not necessary, is mixed into the project that wants to be previewed.
Since LivePreviewAttribute itself has no dependency, it can be solved by separating LiveViewWindow into a separate library.
@SilkyFowl SilkyFowl mentioned this issue Aug 29, 2023
Open
6 tasks
@SilkyFowl SilkyFowl self-assigned this Aug 29, 2023
@SilkyFowl SilkyFowl added the enhancement New feature or request label Aug 29, 2023
@SilkyFowl SilkyFowl mentioned this issue Sep 30, 2023
Merged
SilkyFowl added a commit that referenced this issue Oct 11, 2023
@SilkyFowl
Move LivePreviewAttribute to a separate project
5ab4d01 
This commit addresses issue #25 and includes the following changes:
- Move LivePreviewAttribute from Avalonia.FuncUI.LiveView to a separate project
- Implement minimum functionality for selecting any project for preview in Avalonia.FuncUI.LiveView
- Update LiveViewWindow to use the new LivePreviewAttribute implementation
- Refactor code to use the new LivePreviewAttribute implementation
@SilkyFowl SilkyFowl mentioned this issue Nov 6, 2023
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SilkyFowl SilkyFowl

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SilkyFowl/issue25 SilkyFowl/Avalonia.FuncUI.LiveView
1 participant
@SilkyFowl