Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding item_group_method #11

Conversation

Exempt-Medic
Copy link

@Exempt-Medic Exempt-Medic commented Nov 20, 2024

What is this fixing or adding?

  • Adds item_group_method to ItemPlando allowing users to specify how groups should unroll

How was this tested?

Generating with yamls and unit tests.

@Exempt-Medic Exempt-Medic changed the title Plando items fixes and adding item_group_method Plando items fixes Nov 21, 2024
@Exempt-Medic Exempt-Medic changed the title Plando items fixes Adding item_group_method Nov 21, 2024
@Silvris
Copy link
Owner

Silvris commented Nov 29, 2024

With us being early into the next version's cycle, I think I'd prefer something like this to be a separate PR following the rewrite itself. I personally don't particularly like it, but it probably warrants real discussion.

@Exempt-Medic
Copy link
Author

Works for me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants