MAINT: use fontawesome css variables instead of font names (pydata#1219)

* MAINT: use fontawesome css variables instead of font names * roolback package-lock
SimenZhor · Mar 7, 2023 · 39aa0d7 · 39aa0d7
1 parent 6ec9aed
commit 39aa0d7
Show file tree

Hide file tree

Showing 8 changed files with 9 additions and 16 deletions.
diff --git a/src/pydata_sphinx_theme/assets/styles/base/_base.scss b/src/pydata_sphinx_theme/assets/styles/base/_base.scss
@@ -68,7 +68,7 @@ a {
   &.gitlab {
     &::before {
       color: var(--pst-color-text-muted);
-      font-family: "Font Awesome 6 Brands";
+      font: var(--fa-font-brands);
       margin-right: 0.25rem;
     }
   }

diff --git a/src/pydata_sphinx_theme/assets/styles/components/_breadcrumbs.scss b/src/pydata_sphinx_theme/assets/styles/components/_breadcrumbs.scss
@@ -22,8 +22,7 @@ ul.bd-breadcrumbs {
 
     // Items that aren't the home have a carot to the left
     &:not(.breadcrumb-home):before {
-      font-family: "Font Awesome 6 Free";
-      font-weight: 900;
+      font: var(--fa-font-solid);
       font-size: 0.8rem;
       content: var(--pst-breadcrumb-divider);
       color: var(--pst-color-text-muted);

diff --git a/src/pydata_sphinx_theme/assets/styles/components/_searchbox.scss b/src/pydata_sphinx_theme/assets/styles/components/_searchbox.scss
@@ -39,8 +39,7 @@ div#searchbox {
       &:before {
         content: var(--pst-icon-search-minus);
         color: unset;
-        font-family: "Font Awesome 6 Free";
-        font-weight: 900;
+        font: var(--fa-font-solid);
         margin-right: 0.5rem;
       }
     }

diff --git a/src/pydata_sphinx_theme/assets/styles/components/_versionmodified.scss b/src/pydata_sphinx_theme/assets/styles/components/_versionmodified.scss
@@ -50,11 +50,9 @@ span.versionmodified {
   font-weight: 600;
 
   &:before {
-    font-style: normal;
     margin-right: 0.6rem;
     color: var(--pst-color-info);
-    font-family: "Font Awesome 6 Free";
-    font-weight: 900;
+    font: var(--fa-font-solid);
     content: var(--pst-icon-versionmodified-default);
   }
 }

diff --git a/src/pydata_sphinx_theme/assets/styles/content/_admonitions.scss b/src/pydata_sphinx_theme/assets/styles/content/_admonitions.scss
@@ -45,8 +45,8 @@ div.admonition,
       width: 1rem;
       height: 1rem;
       color: var(--pst-color-info);
-      font-family: "Font Awesome 6 Free";
-      font-weight: 900;
+      font: var(--fa-font-solid);
+      line-height: inherit;
       content: var(--pst-icon-admonition-default);
       opacity: 1;
     }

diff --git a/src/pydata_sphinx_theme/assets/styles/content/_spans.scss b/src/pydata_sphinx_theme/assets/styles/content/_spans.scss
@@ -17,9 +17,8 @@ span.guilabel {
 
 a.reference.download:before {
   content: var(--pst-icon-download);
-  font-family: "Font Awesome 6 Free";
+  font: var(--fa-font-solid);
   font-size: 0.8em;
-  font-weight: 600;
   padding: 0 0.25em;
   color: var(--pst-color-text-muted);
 }
diff --git a/src/pydata_sphinx_theme/assets/styles/sections/_header.scss b/src/pydata_sphinx_theme/assets/styles/sections/_header.scss
@@ -142,8 +142,7 @@
   }
 
   &.nav-external:after {
-    font-family: "Font Awesome 6 Free";
-    font-weight: 900;
+    font: var(--fa-font-solid);
     content: var(--pst-icon-external-link);
     font-size: 0.75em;
     margin-left: 0.3em;

diff --git a/src/pydata_sphinx_theme/assets/styles/sections/_sidebar-primary.scss b/src/pydata_sphinx_theme/assets/styles/sections/_sidebar-primary.scss
@@ -200,8 +200,7 @@ nav.bd-links {
 
     &.reference.external {
       &:after {
-        font-family: "Font Awesome 6 Free";
-        font-weight: 900;
+        font: var(--fa-font-solid);
         content: var(--pst-icon-external-link);
         font-size: 0.75em;
         margin-left: 0.3em;