-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ✨ Added show time on live timeline #217
feat: ✨ Added show time on live timeline #217
Conversation
Hello @DevyankShaw Thanks for you contribution to the package. We would love to test this change and merge it if all goes well in our next release but to achieve the same together could you please resolve the merge conflict in this PR with respects to latest changes on the master? |
Hey @DhavalRKansara will try to resolve this merge conflict by this weekend and let you know once done |
Perfect @DevyankShaw, Thanks for reverting back actively. |
@DhavalRKansara merge conflict is now resolved with respect to the master. Request to review and let me know if you require any further inputs from my side |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check the comments and rebase the PR on the latest changes.
Please make sure that all the checks are passed. |
It's currently WIP. Will update once done by this weekend. |
@ParthBaraiya Rebasing is done and all checks are passed. I hope it is now ready to merge. Let me know if you require anything. |
@ParthBaraiya Can we close this feature at the earliest? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
* master: feat: ✨ Added show time on live timeline (SimformSolutionsPvtLtd#217)
Description
This PR is adding optional functionality that allows users to show time on the live timeline indicator in different views
Earlier
Now
On activating _showTime_ only
On activating _showTime_ and _showTimeBackgroundView_
On activating _showTime_, _showTimeBackgroundView_ and deactivating _showBullet_
On activating _showTime_ and deactivating _showBullet_
Motivation
The designs were approved by the client which had the show time on timeline behavior. I have already implemented the entire day and week view functionality using this package only and don't want to switch to another package just for this behavior. By the way, this is also the core part of the calendar view design as per the latest trends. So thought of creating this PR would help others to choose this package without any hesitation.
Checklist
fix:
,feat:
,docs:
etc).docs
and added dartdoc comments with///
.examples
ordocs
.Breaking Change?
Related Issues
#218