Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ✨ Added show time on live timeline #217

Conversation

DevyankShaw
Copy link
Contributor

@DevyankShaw DevyankShaw commented Apr 23, 2023

Description

This PR is adding optional functionality that allows users to show time on the live timeline indicator in different views

Earlier

image

Now

On activating _showTime_ only

  • DayView
DayView<Event>(
      key: state,
      width: width,
      verticalLineOffset: 0,
      timeLineWidth: 65,
      showLiveTimeLineInAllDays: true,
      liveTimeIndicatorSettings: LiveTimeIndicatorSettings(
        color: Colors.redAccent,
        showTime: true,
      ),
    )
  • WeekView
WeekView<Event>(
      key: state,
      width: width,
      showLiveTimeLineInAllDays: true,
      timeLineWidth: 65,
      liveTimeIndicatorSettings: LiveTimeIndicatorSettings(
        color: Colors.redAccent,
        showTime: true,
      ),
    )

image

On activating _showTime_ and _showTimeBackgroundView_

  • DayView
DayView<Event>(
      key: state,
      width: width,
      verticalLineOffset: 0,
      timeLineWidth: 65,
      showLiveTimeLineInAllDays: true,
      liveTimeIndicatorSettings: LiveTimeIndicatorSettings(
        color: Colors.redAccent,
        showTime: true,
        showTimeBackgroundView: true,
      ),
    )
  • WeekView
WeekView<Event>(
      key: state,
      width: width,
      showLiveTimeLineInAllDays: true,
      timeLineWidth: 65,
      liveTimeIndicatorSettings: LiveTimeIndicatorSettings(
        color: Colors.redAccent,
        showTime: true,
        showTimeBackgroundView: true,
      ),
    )

image

On activating _showTime_, _showTimeBackgroundView_ and deactivating _showBullet_

  • DayView
DayView<Event>(
      key: state,
      width: width,
      verticalLineOffset: 0,
      timeLineWidth: 65,
      showLiveTimeLineInAllDays: true,
      liveTimeIndicatorSettings: LiveTimeIndicatorSettings(
        color: Colors.redAccent,
        showBullet: false,
        showTime: true,
        showTimeBackgroundView: true,
      ),
    )
  • WeekView
WeekView<Event>(
      key: state,
      width: width,
      showLiveTimeLineInAllDays: true,
      timeLineWidth: 65,
      liveTimeIndicatorSettings: LiveTimeIndicatorSettings(
        color: Colors.redAccent,
        showBullet: false,
        showTime: true,
        showTimeBackgroundView: true,
      ),
    )

image

On activating _showTime_ and deactivating _showBullet_

  • DayView
DayView<Event>(
      key: state,
      width: width,
      verticalLineOffset: 0,
      timeLineWidth: 65,
      showLiveTimeLineInAllDays: true,
      liveTimeIndicatorSettings: LiveTimeIndicatorSettings(
        color: Colors.redAccent,
        showBullet: false,
        showTime: true,
      ),
    )
  • WeekView
WeekView<Event>(
      key: state,
      width: width,
      showLiveTimeLineInAllDays: true,
      timeLineWidth: 65,
      liveTimeIndicatorSettings: LiveTimeIndicatorSettings(
        color: Colors.redAccent,
        showBullet: false,
        showTime: true,
      ),
    )

image

Motivation

The designs were approved by the client which had the show time on timeline behavior. I have already implemented the entire day and week view functionality using this package only and don't want to switch to another package just for this behavior. By the way, this is also the core part of the calendar view design as per the latest trends. So thought of creating this PR would help others to choose this package without any hesitation.

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

#218

@ParthBaraiya ParthBaraiya linked an issue May 6, 2023 that may be closed by this pull request
@DhavalRKansara
Copy link
Collaborator

Hello @DevyankShaw Thanks for you contribution to the package. We would love to test this change and merge it if all goes well in our next release but to achieve the same together could you please resolve the merge conflict in this PR with respects to latest changes on the master?

@DevyankShaw
Copy link
Contributor Author

Hey @DhavalRKansara will try to resolve this merge conflict by this weekend and let you know once done

@DhavalRKansara
Copy link
Collaborator

DhavalRKansara commented Aug 9, 2023

Hey @DhavalRKansara will try to resolve this merge conflict by this weekend and let you know once done

Perfect @DevyankShaw, Thanks for reverting back actively.

@DevyankShaw
Copy link
Contributor Author

@DhavalRKansara merge conflict is now resolved with respect to the master.

Request to review and let me know if you require any further inputs from my side

Copy link
Collaborator

@PRBaraiya PRBaraiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the comments and rebase the PR on the latest changes.

lib/src/components/_internal_components.dart Outdated Show resolved Hide resolved
@ParthBaraiya
Copy link
Collaborator

Screenshot 2023-12-13 at 3 53 57 PM There are errors in the code.

@ParthBaraiya
Copy link
Collaborator

Please make sure that all the checks are passed.

@DevyankShaw
Copy link
Contributor Author

DevyankShaw commented Dec 13, 2023

It's currently WIP. Will update once done by this weekend.

@DevyankShaw
Copy link
Contributor Author

@ParthBaraiya Rebasing is done and all checks are passed. I hope it is now ready to merge. Let me know if you require anything.

@DevyankShaw
Copy link
Contributor Author

@ParthBaraiya Can we close this feature at the earliest?

Copy link
Collaborator

@ParthBaraiya ParthBaraiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ParthBaraiya ParthBaraiya merged commit c003d1b into SimformSolutionsPvtLtd:master Feb 21, 2024
1 check passed
dumazy added a commit to dumazy/flutter_calendar_view that referenced this pull request Feb 21, 2024
* master:
  feat: ✨ Added show time on live timeline (SimformSolutionsPvtLtd#217)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] Add to show time on live timeline
4 participants