Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 onDateTap return wrong date when startHour is set #341 #350

Conversation

apurva010
Copy link
Collaborator

  • add startHour minutes (startHour * 60) to DateTime which then passed as arguments to onDateTap

Description

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

Closes #341

- add startHour minutes (startHour * 60) to DateTime which then passed as arguments to onDateTap
@apurva010 apurva010 force-pushed the fix/issue_341_onDateTap_change_week_day_view branch from f115d2b to f83c7ef Compare May 1, 2024 05:56
@vatsaltanna-simformsolutions vatsaltanna-simformsolutions merged commit 189d10e into master May 1, 2024
1 check passed
@vatsaltanna-simformsolutions vatsaltanna-simformsolutions deleted the fix/issue_341_onDateTap_change_week_day_view branch May 1, 2024 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong date onDateTap when startHour != 0
2 participants