Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 fix show border not applying to header in month view #306 #364

Conversation

apurva010
Copy link
Collaborator

@apurva010 apurva010 commented May 8, 2024

Description

  • Show border will apply also to header in month view with showBorder field.

  • showBorder : false
    showBorder

  • showWeekTileBorder : false
    showWeekTileBorder

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

Closes #306

@vatsaltanna-simformsolutions
Copy link
Collaborator

Please add before after screenshots

@apurva010 apurva010 force-pushed the fix/issue_306_show_border_for_header_in_month branch from 260004e to f777066 Compare May 8, 2024 11:06
@apurva010 apurva010 force-pushed the fix/issue_306_show_border_for_header_in_month branch from f777066 to 17382d2 Compare May 8, 2024 13:32
@vatsaltanna-simformsolutions vatsaltanna-simformsolutions merged commit 407f187 into master May 8, 2024
1 check passed
@vatsaltanna-simformsolutions vatsaltanna-simformsolutions deleted the fix/issue_306_show_border_for_header_in_month branch May 8, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Weekday border dose not change with monthview show border false
2 participants