Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: the _InternalDayViewPageState is always Object #371 #375

Merged
merged 2 commits into from
Jun 5, 2024

Conversation

jiazeh
Copy link
Contributor

@jiazeh jiazeh commented May 30, 2024

Description

Fix the problem that _InternalDayViewPageState is always Object.

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

Closes #371

jiazeh added 2 commits May 30, 2024 15:24
…olutionsPvtLtd#371

Fix the problem that `_InternalDayViewPageState` is always Object.
…olutionsPvtLtd#371

Fix the problem that `_InternalDayViewPageState` is always Object.
Copy link
Collaborator

@PRBaraiya PRBaraiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ParthBaraiya ParthBaraiya merged commit e3c127b into SimformSolutionsPvtLtd:master Jun 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generics of _InternalDayViewPageState is always Object?
3 participants