Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Fixes issue #383: ✨ Add action on tap of timestamp in day & week view #419

Merged
merged 1 commit into from
Nov 6, 2024
Merged

feat: Fixes issue #383: ✨ Add action on tap of timestamp in day & week view #419

merged 1 commit into from
Nov 6, 2024

Conversation

shubham-jitiya-simform
Copy link
Contributor

@shubham-jitiya-simform shubham-jitiya-simform commented Nov 5, 2024 •
edited
Loading

Description

  • Used callback to get the timestamp of tapped timeline & execute the given function.

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

Closes issue: #383

@shubham-jitiya-simform shubham-jitiya-simform force-pushed the feature/time_clickable_function branch 3 times, most recently from 65e0cc3 to 632bc1d Compare November 6, 2024 07:07
@shubham-jitiya-simform shubham-jitiya-simform force-pushed the feature/time_clickable_function branch from 632bc1d to 1be329c Compare November 6, 2024 08:23
@shubham-jitiya-simform shubham-jitiya-simform marked this pull request as ready for review November 6, 2024 10:02
PRBaraiya
PRBaraiya approved these changes Nov 6, 2024
View reviewed changes
Copy link
Collaborator

@PRBaraiya PRBaraiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@PRBaraiya PRBaraiya merged commit 3924c93 into master Nov 6, 2024
1 check passed
@ParthBaraiya ParthBaraiya deleted the feature/time_clickable_function branch November 21, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PRBaraiya PRBaraiya PRBaraiya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shubham-jitiya-simform @PRBaraiya