Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: onTooltiClick on withWidget constructor #473

Conversation

tomassasovsky
Copy link

@tomassasovsky tomassasovsky commented Sep 5, 2024

Description

Pretty simple stuff, just adding the onToolTipClick parameter to the withWidget constructor.

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

@aditya-css
Copy link
Collaborator

Hi @tomassasovsky,
Thanks for raising this PR, but I am closing it for the following reason:
We don't have the onTooltipClick parameter for withWidget constructor as there will be no default tooltip but the user provided widget and the user can easily add gesture capabilities in the widget that he provides.

@aditya-css aditya-css closed this Sep 7, 2024
@tomassasovsky
Copy link
Author

The user cannot use a GestureDetector on the tooltip because the internal one already handles the gesture, and since gestures can only be handled by one GestureDetector in the tree, the event gets lost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants