fix: 🐛 Handle null RenderBox in AnchoredOverlay and provide fallback values(#464) #487
+26
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sahil-Simform
force-pushed
the
issue/issue_464_rander_box_error
branch
from
74483d4 to
8472715
Compare
ZameerHaider
approved these changes
Nov 25, 2024
nicomunoz10
approved these changes
Nov 28, 2024
|
@Sahil-Simform could we please merge this and create a new version? |
|
Hi @nicolasWenia , We have a major release planned soon, and this PR will be included as part of it. |
JanakMistry2000
approved these changes
Dec 2, 2024
Sahil-Simform
force-pushed
the
issue/issue_464_rander_box_error
branch
from
8472715 to
248ed24
Compare
aditya-css
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: 🐛 Handle null RenderBox in AnchoredOverlay and provide fallback values(#464)
Description
This PR addresses a bug where AnchoredOverlay was causing crashes when RenderBox was null or not yet laid out.
Added null-safe checks for RenderBox in AnchoredOverlay.
Provided fallback values (Offset.zero and an empty Rect) for safe calculations.
Improved code readability with null-aware operators and comments.
Checklist
fix:,feat:,docs:etc).docsand added dartdoc comments with///.examplesordocs.Breaking Change?
Related Issues
Closes #464