Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-write avg. ensemble op to use analytical gradient #78

Merged
merged 4 commits into from
Oct 19, 2023
Merged

Re-write avg. ensemble op to use analytical gradient #78

merged 4 commits into from
Oct 19, 2023

Conversation

SimonBoothroyd
Copy link
Owner

Description

This PR re-writes the ensemble average to:

  1. take in an existing trajectory - this will allow the distribution of any simulations without needing to worry about how to transfer gradients between workers.
  2. compute the analytical rather than the FD gradient

Status

  • Ready to go

@SimonBoothroyd SimonBoothroyd marked this pull request as ready for review October 19, 2023 21:58
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #78 (fdd2a35) into main (249dfc3) will decrease coverage by 0.26%.
The diff coverage is 94.54%.

@SimonBoothroyd SimonBoothroyd merged commit c6407a4 into main Oct 19, 2023
@SimonBoothroyd SimonBoothroyd deleted the rewrite-ensemble-op branch October 19, 2023 22:01
@SimonBoothroyd SimonBoothroyd restored the rewrite-ensemble-op branch October 19, 2023 22:01
@SimonBoothroyd SimonBoothroyd deleted the rewrite-ensemble-op branch October 19, 2023 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@SimonBoothroyd