Species autocomplete #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue where an answer is rated as wrong if it has whitespace on either end. This happens when entering words on a mobile using auto-complete.
…ers that are in the list.
…me. Use the return type constants properly instead of a mix of bools and InvalidAnswer.
Because got_it_right is now an int and "correct" is 0, but got_it_right was being evaluated as a bool, 0 would evaluate to false. Now it's correctly comparing to constant value.
This makes them sorted automatically when they appear in the auto complete.
Added autocomplete functionality as described on w3schools here: https://www.w3schools.com/howto/howto_js_autocomplete.asp Fixed some html issues (proper structure in index.html as well as some IDs that had spaces in them).
|
Note, these changes include the changes in the other PR (not allowing species not on the list). |
I had accidentally done some of the changes (for the "don't accept invalid species") in the base /scripts/ folder. This commit reverts some of those, but also adds some changes/fixes to the index.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OK, this is working. Not sure if it's nice enough? I would rather the autocomplete dropdown was "on top of the page" instead of inserted into it...
What do you think?
I think I might have broken the "base birdnerd" site with these changes, so at least it's not quite ready to merge in yet :)