Skip to content

Include ValidationFailure.ErrorCode in ExecutionError.Code. #440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SimonCropp merged 1 commit into from
Feb 13, 2021
Merged

Include ValidationFailure.ErrorCode in ExecutionError.Code. #440

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/GraphQL.FluentValidation/ValidationMiddleware.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,8 @@ static ExecutionError ToExecutionError(ValidationFailure failure)
{
return new($"{failure.PropertyName}: {failure.ErrorMessage}")
{
Path = new List<string> {failure.PropertyName}
Path = new List<string> {failure.PropertyName},
Code = failure.ErrorCode
};
}
}
16 changes: 14 additions & 2 deletions src/Tests/IntegrationTests.AsyncComplexInvalid.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,25 @@
"message": "Inner: Inner async test failed msg.",
"path": [
"Inner"
]
],
"extensions": {
"code": "AsyncPredicateValidator",
"codes": [
"AsyncPredicateValidator"
]
}
},
{
"message": "Inner.Content: 'Content' must not be empty.",
"path": [
"Inner.Content"
]
],
"extensions": {
"code": "NotEmptyValidator",
"codes": [
"NotEmptyValidator"
]
}
}
],
"data": {
Expand Down
8 changes: 7 additions & 1 deletion src/Tests/IntegrationTests.AsyncInvalid.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,13 @@
"message": "Content: The specified condition was not met for 'Content'.",
"path": [
"Content"
]
],
"extensions": {
"code": "AsyncPredicateValidator",
"codes": [
"AsyncPredicateValidator"
]
}
}
],
"data": {
Expand Down
16 changes: 14 additions & 2 deletions src/Tests/IntegrationTests.ComplexInvalid.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,25 @@
"message": "Inner.Content: 'Content' must not be empty.",
"path": [
"Inner.Content"
]
],
"extensions": {
"code": "NotEmptyValidator",
"codes": [
"NotEmptyValidator"
]
}
},
{
"message": "Items: 'Items' must not be empty.",
"path": [
"Items"
]
],
"extensions": {
"code": "NotEmptyValidator",
"codes": [
"NotEmptyValidator"
]
}
}
],
"data": {
Expand Down
16 changes: 14 additions & 2 deletions src/Tests/IntegrationTests.ComplexInvalid2.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,25 @@
"message": "Inner: 'Inner' must not be empty.",
"path": [
"Inner"
]
],
"extensions": {
"code": "NotEmptyValidator",
"codes": [
"NotEmptyValidator"
]
}
},
{
"message": "Items: 'Items' must not be empty.",
"path": [
"Items"
]
],
"extensions": {
"code": "NotEmptyValidator",
"codes": [
"NotEmptyValidator"
]
}
}
],
"data": {
Expand Down
16 changes: 14 additions & 2 deletions src/Tests/IntegrationTests.DerivedComplexInvalid.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,25 @@
"message": "Inner.Content: 'Content' must not be empty.",
"path": [
"Inner.Content"
]
],
"extensions": {
"code": "NotEmptyValidator",
"codes": [
"NotEmptyValidator"
]
}
},
{
"message": "Items: 'Items' must not be empty.",
"path": [
"Items"
]
],
"extensions": {
"code": "NotEmptyValidator",
"codes": [
"NotEmptyValidator"
]
}
}
],
"data": {
Expand Down
8 changes: 7 additions & 1 deletion src/Tests/IntegrationTests.Invalid.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,13 @@
"message": "Content: 'Content' must not be empty.",
"path": [
"Content"
]
],
"extensions": {
"code": "NotEmptyValidator",
"codes": [
"NotEmptyValidator"
]
}
}
],
"data": {
Expand Down