GetValidatedArgument[Async] uses context.RequestServices#760
Merged
SimonCropp merged 2 commits intoSimonCropp:mainfrom May 3, 2023
Merged
GetValidatedArgument[Async] uses context.RequestServices#760SimonCropp merged 2 commits intoSimonCropp:mainfrom
SimonCropp merged 2 commits intoSimonCropp:mainfrom
Conversation
Using the schema to access the root service provider made it impossible to use validators with a scoped lifetime, or with scoped dependencies. By using context.RequestServices we can access the service provider that's appropriate for the current scope (Asp.Net request scope, or a child scope created for a field resolver).
mbcrawfo
force-pushed
the
use-scoped-service-provider
branch
from
e98a30b to
cdf8fc8
Compare
mbcrawfo
changed the title
Contributor
Author
|
@SimonCropp any feedback on these changes? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using the schema to access the root service provider made it impossible to use validators with a scoped lifetime, or with scoped dependencies. By using context.RequestServices we can access the service provider that's appropriate for the current scope (Asp.Net request scope, or a child scope created for a field resolver).