remove trailing newline

fixes #431
SimonCropp · Nov 19, 2021 · 5355ee3 · 5355ee3
1 parent a291132
commit 5355ee3
Show file tree

Hide file tree

Showing 26 changed files with 8 additions and 26 deletions.
diff --git a/docs/mdsource/github-action.source.md b/docs/mdsource/github-action.source.md
@@ -16,4 +16,4 @@ This action performs the following tasks:
 
 ## More Info
 
- * [Software installed on GitHub-hosted runners](https://help.github.com/en/actions/automating-your-workflow-with-github-actions/software-installed-on-github-hosted-runners)
+ * [Software installed on GitHub-hosted runners](https://help.github.com/en/actions/automating-your-workflow-with-github-actions/software-installed-on-github-hosted-runners)
diff --git a/docs/mdsource/header.source.md b/docs/mdsource/header.source.md
@@ -29,4 +29,4 @@ To insert a newline use `\n`
 
 ```ps
 mdsnippets --header "GENERATED FILE\nSource File: {relativePath}"
-```
+```
diff --git a/src/Directory.Build.props b/src/Directory.Build.props
@@ -2,7 +2,7 @@
 <Project>
   <PropertyGroup>
     <NoWarn>CS1591</NoWarn>
-    <Version>24.2.0</Version>
+    <Version>24.2.1</Version>
     <AssemblyVersion>1.0.0</AssemblyVersion>
     <PackageTags>Markdown, Snippets, mdsnippets, documentation, MarkdownSnippets</PackageTags>
     <Description>Extracts snippets from code files and merges them into markdown documents.</Description>

diff --git a/src/MarkdownSnippets/Processing/MarkdownProcessor.cs b/src/MarkdownSnippets/Processing/MarkdownProcessor.cs
@@ -112,10 +112,14 @@ public ProcessResult Apply(TextReader textReader, TextWriter writer, string? fil
         var lines = Lines.ReadAllLines(textReader, null).ToList();
         writer.NewLine = newLine;
         var result = Apply(lines, newLine, file);
-        foreach (var line in lines)
+
+        for (var index = 0; index < lines.Count - 1; index++)
         {
+            var line = lines[index];
             writer.WriteLine(line.Current);
         }
+
+        writer.Write(lines.Last().Current);
 
         return result;
     }

diff --git a/src/Tests/MarkdownProcessor/MarkdownProcessorTests.MissingInclude.verified.txt b/src/Tests/MarkdownProcessor/MarkdownProcessorTests.MissingInclude.verified.txt
@@ -6,5 +6,4 @@ before
 ** Could not find include 'theKey' ** <!-- singleLineInclude: theKey -->
 
 after
-
 }
diff --git a/src/Tests/MarkdownProcessor/MarkdownProcessorTests.MixedNewlinesInFile.verified.txt b/src/Tests/MarkdownProcessor/MarkdownProcessorTests.MixedNewlinesInFile.verified.txt
@@ -25,5 +25,4 @@ c
 d
 ```
 <!-- endSnippet -->
-
 }
diff --git a/src/Tests/MarkdownProcessor/MarkdownProcessorTests.Simple.verified.txt b/src/Tests/MarkdownProcessor/MarkdownProcessorTests.Simple.verified.txt
@@ -78,5 +78,4 @@ From
 File
 ```
 <!-- endSnippet -->
-
 }
diff --git a/src/Tests/MarkdownProcessor/MarkdownProcessorTests.Simple_Overwrite.verified.txt b/src/Tests/MarkdownProcessor/MarkdownProcessorTests.Simple_Overwrite.verified.txt
@@ -78,5 +78,4 @@ From
 File
 ```
 <!-- endSnippet -->
-
 }
diff --git a/src/Tests/MarkdownProcessor/MarkdownProcessorTests.SkipHeadingBeforeToc.verified.txt b/src/Tests/MarkdownProcessor/MarkdownProcessorTests.SkipHeadingBeforeToc.verified.txt
@@ -13,5 +13,4 @@ Text1
 ## Heading 2
 
 Text2
-
 }
diff --git a/src/Tests/MarkdownProcessor/MarkdownProcessorTests.SnippetInInclude.verified.txt b/src/Tests/MarkdownProcessor/MarkdownProcessorTests.SnippetInInclude.verified.txt
@@ -22,5 +22,4 @@ Snippet
 <!-- endInclude -->
 
 some other text
-
 }
diff --git a/src/Tests/MarkdownProcessor/MarkdownProcessorTests.SnippetInIncludeLast.verified.txt b/src/Tests/MarkdownProcessor/MarkdownProcessorTests.SnippetInIncludeLast.verified.txt
@@ -22,5 +22,4 @@ Snippet
 <!-- endInclude -->
 
 some other text
-
 }
diff --git a/src/Tests/MarkdownProcessor/MarkdownProcessorTests.TableInInclude.verified.txt b/src/Tests/MarkdownProcessor/MarkdownProcessorTests.TableInInclude.verified.txt
@@ -10,5 +10,4 @@ some text
 <!-- endInclude -->
 
 some other text
-
 }
diff --git a/src/Tests/MarkdownProcessor/MarkdownProcessorTests.Toc.verified.txt b/src/Tests/MarkdownProcessor/MarkdownProcessorTests.Toc.verified.txt
@@ -16,5 +16,4 @@ Text1
 ## Heading 2
 
 Text2
-
 }
diff --git a/src/Tests/MarkdownProcessor/MarkdownProcessorTests.Toc1.verified.txt b/src/Tests/MarkdownProcessor/MarkdownProcessorTests.Toc1.verified.txt
@@ -12,5 +12,4 @@ Text1
 ## Heading 2
 
 Text2
-
 }
diff --git a/...Tests/MarkdownProcessor/MarkdownProcessorTests.TocRetainedIfNoHeadingsInFile.verified.txt b/...Tests/MarkdownProcessor/MarkdownProcessorTests.TocRetainedIfNoHeadingsInFile.verified.txt
@@ -10,5 +10,4 @@ This document has no headings.
 
 An empty toc section should be generated, in case
 any headings are added in future.
-
 }
diff --git a/src/Tests/MarkdownProcessor/MarkdownProcessorTests.Toc_Overwrite.verified.txt b/src/Tests/MarkdownProcessor/MarkdownProcessorTests.Toc_Overwrite.verified.txt
@@ -16,5 +16,4 @@ Text1
 ## Heading 2
 
 Text2
-
 }
diff --git a/src/Tests/MarkdownProcessor/MarkdownProcessorTests.WithDoubleInclude.verified.txt b/src/Tests/MarkdownProcessor/MarkdownProcessorTests.WithDoubleInclude.verified.txt
@@ -7,5 +7,4 @@ theValue1 <!-- include: theKey. path: /thePath -->
 theValue2 <!-- endInclude -->
 
 after
-
 }
diff --git a/...MarkdownProcessor/MarkdownProcessorTests.WithEmptyMultiLineInclude_Overwrite.verified.txt b/...MarkdownProcessor/MarkdownProcessorTests.WithEmptyMultiLineInclude_Overwrite.verified.txt
@@ -7,5 +7,4 @@ one <!-- include: theKey. path: /thePath -->
 two <!-- endInclude -->
 
 after
-
 }
diff --git a/src/Tests/MarkdownProcessor/MarkdownProcessorTests.WithEmptyMultipleInclude.verified.txt b/src/Tests/MarkdownProcessor/MarkdownProcessorTests.WithEmptyMultipleInclude.verified.txt
@@ -8,5 +8,4 @@ before
  <!-- endInclude -->
 
 after
-
 }
diff --git a/...ests/MarkdownProcessor/MarkdownProcessorTests.WithMultiLineInclude_Overwrite.verified.txt b/...ests/MarkdownProcessor/MarkdownProcessorTests.WithMultiLineInclude_Overwrite.verified.txt
@@ -7,5 +7,4 @@ theValue1 <!-- include: theKey. path: /thePath -->
 theValue2 <!-- endInclude -->
 
 after
-
 }
diff --git a/src/Tests/MarkdownProcessor/MarkdownProcessorTests.WithMultiLineSnippet.verified.txt b/src/Tests/MarkdownProcessor/MarkdownProcessorTests.WithMultiLineSnippet.verified.txt
@@ -8,5 +8,4 @@ long
 Snippet <!-- endInclude -->
 
 after
-
 }
diff --git a/src/Tests/MarkdownProcessor/MarkdownProcessorTests.WithMultipleInclude.verified.txt b/src/Tests/MarkdownProcessor/MarkdownProcessorTests.WithMultipleInclude.verified.txt
@@ -8,5 +8,4 @@ theValue2
 theValue3 <!-- endInclude -->
 
 after
-
 }
diff --git a/src/Tests/MarkdownProcessor/MarkdownProcessorTests.WithSingleInclude.verified.txt b/src/Tests/MarkdownProcessor/MarkdownProcessorTests.WithSingleInclude.verified.txt
@@ -6,5 +6,4 @@ before
 theValue1 <!-- singleLineInclude: theKey. path: /thePath -->
 
 after
-
 }
diff --git a/src/Tests/MarkdownProcessor/MarkdownProcessorTests.WithSingleInclude_Overwrite.verified.txt b/src/Tests/MarkdownProcessor/MarkdownProcessorTests.WithSingleInclude_Overwrite.verified.txt
@@ -6,5 +6,4 @@ before
 theValue1 <!-- singleLineInclude: theKey. path: /thePath -->
 
 after
-
 }
diff --git a/src/Tests/MarkdownProcessor/MarkdownProcessorTests.WithSingleSnippet.verified.txt b/src/Tests/MarkdownProcessor/MarkdownProcessorTests.WithSingleSnippet.verified.txt
@@ -6,5 +6,4 @@ before
 Snippet <!-- singleLineInclude: theKey. path: thePath -->
 
 after
-
 }
diff --git a/src/Tests/MarkdownProcessor/MarkdownProcessorTests.WithTwoLineSnippet.verified.txt b/src/Tests/MarkdownProcessor/MarkdownProcessorTests.WithTwoLineSnippet.verified.txt
@@ -7,5 +7,4 @@ the <!-- include: theKey. path: thePath -->
 Snippet <!-- endInclude -->
 
 after
-
 }
Original file line number	Diff line number	Diff line change
Expand Up		@@ -16,4 +16,4 @@ This action performs the following tasks:

		## More Info

		* [Software installed on GitHub-hosted runners](https://help.github.com/en/actions/automating-your-workflow-with-github-actions/software-installed-on-github-hosted-runners)
		* [Software installed on GitHub-hosted runners](https://help.github.com/en/actions/automating-your-workflow-with-github-actions/software-installed-on-github-hosted-runners)
-Original file line number
+Diff line change
@@ Expand Up / @@ -29,4 +29,4 @@ To insert a newline use `\n` @@
     ```ps
     mdsnippets --header "GENERATED FILE\nSource File: {relativePath}"
-    ```
+    ```
Original file line number	Diff line number	Diff line change
Expand Up		@@ -6,5 +6,4 @@ before
		Could not find include 'theKey' <!-- singleLineInclude: theKey -->

		after

		}
Original file line number	Diff line number	Diff line change
Expand Up		@@ -22,5 +22,4 @@ Snippet
		<!-- endInclude -->

		some other text

		}
Original file line number	Diff line number	Diff line change
Expand Up		@@ -10,5 +10,4 @@ some text
		<!-- endInclude -->

		some other text

		}
Original file line number	Diff line number	Diff line change
Expand Up		@@ -10,5 +10,4 @@ This document has no headings.

		An empty toc section should be generated, in case
		any headings are added in future.

		}
Original file line number	Diff line number	Diff line change
Expand Up		@@ -7,5 +7,4 @@ theValue1 <!-- include: theKey. path: /thePath -->
		theValue2 <!-- endInclude -->

		after

		}
Original file line number	Diff line number	Diff line change
Expand Up		@@ -7,5 +7,4 @@ one <!-- include: theKey. path: /thePath -->
		two <!-- endInclude -->

		after

		}
Original file line number	Diff line number	Diff line change
Expand Up		@@ -8,5 +8,4 @@ long
		Snippet <!-- endInclude -->

		after

		}
Original file line number	Diff line number	Diff line change
Expand Up		@@ -8,5 +8,4 @@ theValue2
		theValue3 <!-- endInclude -->

		after

		}