-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kcov with --coveralls-id uploads to coveralls, but file browsing is not available #358
Comments
Hmm.. I wrote #346 a while ago, so I'm not quite sure what needs to be done to get it working. It sounds to me like some sort of mapping between github and the files in the coverage report is missing, since I guess coveralls will get the actual source files from there. Do you have a link to your repo? |
I just reviewed source code of In that zip file, a file named
Also,
|
Well, it works with travis-ci, so I think the actual source code itself should not be strictly required: https://coveralls.io/builds/37528394/source?filename=src%2Fconfiguration.cc I think in the github actions case it doesn't know about where to find the source file (at github :-)). Perhaps an option could be to add the source-string in the source file object, so that the source file itself is sent with the request. |
I see this in source code of Coveralls writer. Can it be set somehow from kcov ? |
Yes, through
as an argument to kcov. |
Sadly, it didn't work. Reading their API documentation, it states:
You can close now if you think this is not needed. Generating reports using By the way, kcov is great so thank you 🥇 |
Thanks for testing! I think adding the source-string to coveralls would be worth trying, so let's keep it open for that. |
No, I haven't been working on this, sorry. The source-string would be a brutal way of doing it but hopefully it would work. |
I implemented this, although I haven't tested it against the "real" coveralls myself (only looking in the file output). It's available in the
for it to be active. If it appears to work, I'll merge the branch. |
Hi, Can you elaborate the above line? |
Like this, for example
so this is just another option to kcov, only that the syntax looks a bit strange :-) |
Does it show up in your coveralls.out file if you run it manually? Are the source lines now visible? |
Below is the coveralls.out when I run it manually: |
But is this with --configure=... as above? There should also be a source:-section with the actual script sources. At least if built from the branch above. |
Hello.
I'm trying to use
kcov
with Crystal lang and locally it works. The command in GitHub Actions is similar to one I use locally:but the problem is, files are available but can't be browsed to see what is covered.
Do you know solution to this or am I missing something ?
The text was updated successfully, but these errors were encountered: