Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes with strange 'sv' #160

Closed
mikejohnstn opened this issue Nov 1, 2013 · 3 comments
Closed

Changes with strange 'sv' #160

mikejohnstn opened this issue Nov 1, 2013 · 3 comments
Assignees
Labels
Milestone

Comments

@mikejohnstn
Copy link
Contributor

From @fredrocious:

2013-10-31_23:21:14.53933 ERROR:root:couldn't process change: {'ccid': 'fb0c2d2d443c4352929fa08650b19794', 'sv': '8f.8', 'clientid': 'osx-6195556fa72f449db169bbc03b7e3367', 'o': 'M', 'v': {'index': {'o': 'r', 'v': 126}}, 'id': 'rolleiflex_2'} chalk-bump-f49.tag osx-6195556fa72f449db169bbc03b7e3367

Note 'sv' field here is '8f.8'

We get these occasionally, I think @jleandroperez may have looked at this already but wanted to make sure

@ghost ghost assigned jleandroperez Nov 1, 2013
@mikejohnstn
Copy link
Contributor Author

@fredrocious I did a review of simperium-ios and simplenote-osx. I don't think it's possible to create non-encoded tags anymore, so this could be a lingering tag from before.

Should we disallow the creation of objects whose keys have a period in them on the server-side? And cleanup any that are in there?

@chengfred
Copy link
Contributor

We need "." in them currently to support usernames as entity keys used for presence -

The old http methods escaped the id as it accessed over url but this isn't needed on websocket - I think if we just make explicit the logic on the entity commands should be to take the last "." for the version we should be ok, nothing ambiguous.

@mikejohnstn
Copy link
Contributor Author

So...key is always from start of string to last "." and version is always after last period. I'll make this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants