Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Rebase for Objects that Trigger +2 Errors #316

Closed
jleandroperez opened this issue Jul 22, 2014 · 0 comments · Fixed by #317
Closed

Disable Rebase for Objects that Trigger +2 Errors #316

jleandroperez opened this issue Jul 22, 2014 · 0 comments · Fixed by #317
Assignees
Milestone

Comments

@jleandroperez
Copy link
Contributor

We're seeing a loop in which:

  1. Client sends local changes to the backend.
  2. On Error (405 / 417 / 440), the full object's data will get sent to the backend.
  3. Full data message from the previous step gets rejected.
  4. ReIndex kicks in.
  5. Local pending changes get rebased
  6. Back to step 1.

As a counter measure, let's selectively disable the rebase mechanism for those objects that go through step 3.

This loop is probably related to Issue #314

Backend Logs:

    client sends change (sv=9489),
    server rejects with 440,
    client sends change (sv=9489, d=fulldata),
    server accepts,
    client sends change (sv=9489),
    server rejects 440,
    client sends change (sv=9489, d=fulldata),
    server accepts,
    client sends change (sv=9489),
    server rejects 440,
    client sends change (sv=9489, d=fulldata),
    server rejects 412,
    client appears to re-index,
    client sends change (sv=9489),
    server rejects 440,
    client sends change (sv=9489, d=fulldata),
    server rejects 412

/cc @fredrocious

@jleandroperez jleandroperez added this to the v0.6.7 milestone Jul 22, 2014
@jleandroperez jleandroperez self-assigned this Jul 22, 2014
@jleandroperez jleandroperez changed the title Disable Rebase for objects with local changes that trigger +2 Backend Errors Disable Rebase for Objects that trigger +2 Backend Errors Jul 22, 2014
@jleandroperez jleandroperez changed the title Disable Rebase for Objects that trigger +2 Backend Errors Disable Rebase for Objects that Trigger +2 Errors Jul 22, 2014
jleandroperez added a commit that referenced this issue Jul 23, 2014
…n-error

Selectively Disable Rebase on Error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant